Mozilla won't build with XCode 3.1

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Matthew Gertner, Assigned: Matthew Gertner)

Tracking

({fixed1.8.1.15})

Trunk
x86
Mac OS X
fixed1.8.1.15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Makefile:69: /Users/matthewgertner/Development/mozilla//build.mk: No such file or directory
make[1]: *** No rule to make target `/Users/matthewgertner/Development/mozilla//build.mk'.  Stop.

Problem seems to be that the generated autoconf.mk is empty. I encountered the issue in my Firefox build but it looks more general (see http://forums.mozillazine.org/viewtopic.php?t=635070 for the same problem building Thunderbird).
Version: unspecified → Trunk

Comment 1

10 years ago
I've filed this with Apple as RADR #5788532
(Assignee)

Comment 2

10 years ago
Created attachment 308173 [details] [diff] [review]
Take only the last line of the post-processed xcodebuild version string

Apparently xcodebuild now outputs a two line version string. This wasn't anticipated by our configure script, and it results in a newline in the value of XCODEBUILD_VERSION. This breaks the processing of CONFIG_FILES.
Assignee: nobody → matthew
Status: NEW → ASSIGNED
Attachment #308173 - Flags: review?(ted.mielczarek)
Attachment #308173 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

10 years ago
Attachment #308173 - Flags: approval1.9?

Comment 3

10 years ago
This fix makes unnecessary assumptions, imo. 
If Apple feels like changing the number of output lines once, then why shouldn't they do it again and eg. make the version number appear in the second of three lines?
If Apple changes the format completely, we're out of luck (of course), but until then 

$PBBUILD -version 2>/dev/null | xargs | sed -e 's/.*DevToolsCore-\([0-9]*\).*/\1/'

should do the trick more tolerantly.
(Assignee)

Comment 4

10 years ago
Sounds good to me. Want to propose a new patch?
Do we need another patch here, or is this approval request still valid?

Comment 6

10 years ago
(In reply to comment #5)
> Do we need another patch here, or is this approval request still valid?

I think we should get this in now. People have been complaining about this since friday. Can we just get this in asap, and then re-request approval if someone steps up and provides another patch?
Comment on attachment 308173 [details] [diff] [review]
Take only the last line of the post-processed xcodebuild version string

Approving for damon by proxy.
Attachment #308173 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 8

10 years ago
Karsten told me he can get a new patch up but not immediately, so let's get this checked in and we can push through a new patch when it's ready.
Keywords: checkin-needed

Comment 9

10 years ago
I checked this into trunk. Keeping this bug open for Karsten's patch.

As soon as we have a final patch, I think we should nominate for branches as well.
Keywords: checkin-needed

Comment 10

10 years ago
Created attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Patch for my proposed more stable alternative, using xargs to flatten the output into a single line before sed(at)ing. ;-)
Attachment #308704 - Flags: review?

Updated

10 years ago
Attachment #308704 - Flags: review? → review?(ted.mielczarek)
Attachment #308704 - Flags: review?(ted.mielczarek) → review+

Updated

10 years ago
Attachment #308704 - Flags: approval1.9?
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

a1.9+=damons
Attachment #308704 - Flags: approval1.9? → approval1.9+

Comment 12

10 years ago
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Landed on trunk.
Attachment #308704 - Attachment description: more stable variant using xargs → more stable variant using xargs [checked in]

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 13

10 years ago
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

I guess this would be nice to have on the branches as well?

Comment 14

10 years ago
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Requesting 1.8 approval - if anybody still needs 1.8.0, feel free to request approval for that as well.
Attachment #308704 - Flags: approval1.8.1.14?
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

approved for 1.8.1.14, a=dveditz for release-drivers
Attachment #308704 - Flags: approval1.8.1.14? → approval1.8.1.14+

Comment 16

10 years ago
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Landed on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1.14
Blocks: 433203
Matthew, can you check to see if you can build 1.8 branch now?
(Assignee)

Comment 18

9 years ago
Al, I just got back from vacation. Do you still need someone to test this?
(In reply to comment #18)
> Al, I just got back from vacation. Do you still need someone to test this?
> 

Yes, no one verified this for 2.0.0.15 before it was released. Since it wasn't a security issue, that wasn't a blocker but it would be good to have it verified.
You need to log in before you can comment on or make changes to this bug.