Mozilla won't build with XCode 3.1

RESOLVED FIXED

Status

defect
RESOLVED FIXED
12 years ago
Last year

People

(Reporter: matthew.gertner, Assigned: matthew.gertner)

Tracking

({fixed1.8.1.15})

Trunk
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Makefile:69: /Users/matthewgertner/Development/mozilla//build.mk: No such file or directory
make[1]: *** No rule to make target `/Users/matthewgertner/Development/mozilla//build.mk'.  Stop.

Problem seems to be that the generated autoconf.mk is empty. I encountered the issue in my Firefox build but it looks more general (see http://forums.mozillazine.org/viewtopic.php?t=635070 for the same problem building Thunderbird).
Version: unspecified → Trunk
I've filed this with Apple as RADR #5788532
Apparently xcodebuild now outputs a two line version string. This wasn't anticipated by our configure script, and it results in a newline in the value of XCODEBUILD_VERSION. This breaks the processing of CONFIG_FILES.
Assignee: nobody → matthew
Status: NEW → ASSIGNED
Attachment #308173 - Flags: review?(ted.mielczarek)
Attachment #308173 - Flags: review?(ted.mielczarek) → review+
Attachment #308173 - Flags: approval1.9?
This fix makes unnecessary assumptions, imo. 
If Apple feels like changing the number of output lines once, then why shouldn't they do it again and eg. make the version number appear in the second of three lines?
If Apple changes the format completely, we're out of luck (of course), but until then 

$PBBUILD -version 2>/dev/null | xargs | sed -e 's/.*DevToolsCore-\([0-9]*\).*/\1/'

should do the trick more tolerantly.
Sounds good to me. Want to propose a new patch?
Do we need another patch here, or is this approval request still valid?
(In reply to comment #5)
> Do we need another patch here, or is this approval request still valid?

I think we should get this in now. People have been complaining about this since friday. Can we just get this in asap, and then re-request approval if someone steps up and provides another patch?
Comment on attachment 308173 [details] [diff] [review]
Take only the last line of the post-processed xcodebuild version string

Approving for damon by proxy.
Attachment #308173 - Flags: approval1.9? → approval1.9+
Karsten told me he can get a new patch up but not immediately, so let's get this checked in and we can push through a new patch when it's ready.
Keywords: checkin-needed
I checked this into trunk. Keeping this bug open for Karsten's patch.

As soon as we have a final patch, I think we should nominate for branches as well.
Keywords: checkin-needed
Patch for my proposed more stable alternative, using xargs to flatten the output into a single line before sed(at)ing. ;-)
Attachment #308704 - Flags: review?
Attachment #308704 - Flags: review? → review?(ted.mielczarek)
Attachment #308704 - Flags: review?(ted.mielczarek) → review+
Attachment #308704 - Flags: approval1.9?
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

a1.9+=damons
Attachment #308704 - Flags: approval1.9? → approval1.9+
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Landed on trunk.
Attachment #308704 - Attachment description: more stable variant using xargs → more stable variant using xargs [checked in]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

I guess this would be nice to have on the branches as well?
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Requesting 1.8 approval - if anybody still needs 1.8.0, feel free to request approval for that as well.
Attachment #308704 - Flags: approval1.8.1.14?
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

approved for 1.8.1.14, a=dveditz for release-drivers
Attachment #308704 - Flags: approval1.8.1.14? → approval1.8.1.14+
Comment on attachment 308704 [details] [diff] [review]
more stable variant using xargs [checked in]

Landed on MOZILLA_1_8_BRANCH.
Matthew, can you check to see if you can build 1.8 branch now?
Al, I just got back from vacation. Do you still need someone to test this?
(In reply to comment #18)
> Al, I just got back from vacation. Do you still need someone to test this?
> 

Yes, no one verified this for 2.0.0.15 before it was released. Since it wasn't a security issue, that wasn't a blocker but it would be good to have it verified.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.