421773 - autocomplete (awesome bar) shows a non-integer number of items (half height entries) if some pages lack titles

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Jesse Ruderman]

Attachment: screenshot

For a while I've been noticing that sometimes Firefox shows a non-integer number of autocomplete results.  I just figured out what triggers it: pages without titles.  Their rows in autocomplete are shorter, causing part of an extra entry to appear.

(Ideally, some title would be shown, but I think that's mostly orthogonal to the menu-layout issue.)

Comment 1

[Ed Lee :Mardak]

The effect isn't as big when the font size is smaller, but we're calculating the height of the whole popup based on <the number of results> times <the height of the first row>. The heights are different because the font sizes forces the row to be bigger (and actually prevents the favicon from butting against the top of the row).

Comment 2

[Ed Lee :Mardak]

stephend: Visit a page that doesn't have a title like http://ed.agadak.net/blank and search for that page. Make sure it has a title.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008043004 Minefield/3.0pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008043004 Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008043007 Minefield/3.0pre

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5310