URLs without corresponding title are displayed with a blank title (which isn't full-height)

VERIFIED FIXED in Firefox 3

Status

()

Firefox
Address Bar
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Simon Bünzli, Assigned: Mardak)

Tracking

({polish})

Trunk
Firefox 3
polish
Points:
---
Bug Flags:
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixes bug 421773], URL)

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

10 years ago
See the URL (from bug 421773) for the effect. Suggestions:

* only display the URL on a single line
* use the same string which is displayed on the tab (i.e. the URL itself)
* display a non-searchable "(no title)" (this string is already used for name-less bookmarks)

The second or third solution would both also fix bug 421773.
(Assignee)

Comment 1

10 years ago
Created attachment 312836 [details] [diff] [review]
v1

Show the url in place of a blank title.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #312836 - Flags: ui-review?(beltzner)
Attachment #312836 - Flags: review?(gavin.sharp)
Comment on attachment 312836 [details] [diff] [review]
v1

I'm kinda debating whether we should do this in places' nsIAutocompleteSearch implementation instead, but this is fine I guess.
Attachment #312836 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

10 years ago
Created attachment 312988 [details]
screenshot of trunk
(Assignee)

Comment 4

10 years ago
Created attachment 312989 [details]
screenshot of v1
(Assignee)

Comment 5

10 years ago
Created attachment 312990 [details]
screenshot of v1
Attachment #312989 - Attachment is obsolete: true
(Assignee)

Comment 6

10 years ago
Created attachment 312991 [details]
screenshot of trunk
Attachment #312988 - Attachment is obsolete: true
Comment on attachment 312836 [details] [diff] [review]
v1

uir+a
Attachment #312836 - Flags: ui-review?(beltzner)
Attachment #312836 - Flags: ui-review+
Attachment #312836 - Flags: approval1.9+
(Assignee)

Comment 8

10 years ago
Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.133; previous revision: 1.132
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixes bug 421773]
Target Milestone: --- → Firefox 3
Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre)
Gecko/2008043004 Minefield/3.0pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008043004
Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008043007
Minefield/3.0pre

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5310
Status: RESOLVED → VERIFIED
Flags: in-litmus+
You need to log in before you can comment on or make changes to this bug.