424213 - URLs without corresponding title are displayed with a blank title (which isn't full-height)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Simon Bünzli]

See the URL (from bug 421773) for the effect. Suggestions:

* only display the URL on a single line
* use the same string which is displayed on the tab (i.e. the URL itself)
* display a non-searchable "(no title)" (this string is already used for name-less bookmarks)

The second or third solution would both also fix bug 421773.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Show the url in place of a blank title.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 312836 [details] [diff] [review]
v1

I'm kinda debating whether we should do this in places' nsIAutocompleteSearch implementation instead, but this is fine I guess.

Comment 3

[Ed Lee :Mardak]

Attachment: screenshot of trunk

Comment 4

[Ed Lee :Mardak]

Attachment: screenshot of v1

Comment 5

[Ed Lee :Mardak]

Attachment: screenshot of v1

Comment 6

[Ed Lee :Mardak]

Attachment: screenshot of trunk

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312836 [details] [diff] [review]
v1

uir+a

Comment 8

[Ed Lee :Mardak]

Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.133; previous revision: 1.132
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre)
Gecko/2008043004 Minefield/3.0pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008043004
Minefield/3.0pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008043007
Minefield/3.0pre

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5310