Remove fake-account hooks from front-end

RESOLVED FIXED

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Joey Minta, Assigned: Joey Minta)

Tracking

Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [T.M.=Thunderbird 3.0a1])

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 308288 [details] [diff] [review]
patch

As discussed previously, the fake-account stuff has become useless at this point.  This patch removes the front-end hooks from Thunderbird.
Attachment #308288 - Flags: review?(philringnalda)
Comment on attachment 308288 [details] [diff] [review]
patch

>+++ b/mail/base/content/msgMail3PaneWindow.js	Sun Mar 09 09:09:18 2008 -0400

There's a var k = 0; up here that can go, since you're making it unused.

>     for(var i = 0; i < rangeCount; i++)

Bleah. While you're here, a space after the for, por favor.

>-          if (folderResource.Value != "http://home.netscape.com/NC-rdf#PageTitleFakeAccount") {
>-            var msgFolder = folderResource.QueryInterface(Components.interfaces.nsIMsgFolder);
>-            if(msgFolder)
>-              folderArray[k++] = msgFolder;
>-          }
>+          var msgFolder = folderResource.QueryInterface(Components.interfaces.nsIMsgFolder);
>+          folderArray.push(msgFolder);


r=me, if you're absolutely certain the if (msgFolder) isn't needed, that we'll either blow up or just happily push null if something goes wrong.
Attachment #308288 - Flags: review?(philringnalda) → review+
(Assignee)

Comment 2

10 years ago
Changes made, patch checked in. (QI throws in js, it doesn't return null, so we'll blow up, and we would have already)

Checking in mail/base/content/mail3PaneWindowCommands.js;
/cvsroot/mozilla/mail/base/content/mail3PaneWindowCommands.js,v  <--  mail3PaneWindowCommands.js
new revision: 1.43; previous revision: 1.42
done
Checking in mail/base/content/mailContextMenus.js;
/cvsroot/mozilla/mail/base/content/mailContextMenus.js,v  <--  mailContextMenus.js
new revision: 1.30; previous revision: 1.29
done
Checking in mail/base/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v  <--  msgMail3PaneWindow.js
new revision: 1.145; previous revision: 1.144
done
Removing mail/themes/qute/mail/fakeAccount.css;
/cvsroot/mozilla/mail/themes/qute/mail/fakeAccount.css,v  <--  fakeAccount.css
new revision: delete; previous revision: 1.1
done
Checking in mail/themes/qute/mail/jar.mn;
/cvsroot/mozilla/mail/themes/qute/mail/jar.mn,v  <--  jar.mn
new revision: 1.23; previous revision: 1.22
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Whiteboard: [T.M.=Thunderbird 3.0a1]
You need to log in before you can comment on or make changes to this bug.