422630 - [Pinstripe] Fix groupbox theme regression caused by bug 421814

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Stefan [:stefanh]]

When bug 421814 is resolved, the style rules for groupboxes in the pref window has to be adjusted.

Comment 1

[Stefan [:stefanh]]

Attachment: unregress Sunbird

This will make your pref window groupboxes look ok again on trunk. I made the patch cross-commit friendly, so it should work fine on your 2 1.8 branches (not tested there, but I think it's clear that it should work).

Comment 2

[Stefan [:stefanh]]

Comment on attachment 309170 [details] [diff] [review]
unregress Sunbird

So, i never noticed that michael.buettner didn't do reviews anymore... Obviously you're focused on branch atm (otherwise you'd have screamed for a long time ago) ;-)

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Stefan, sorry for the delay. I'll be reviewing this as soon as I have the mac available. 

Comment 4

[Daniel Boelzle [:dbo]]

patch makes the prefs group boxes look ok again

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 309170 [details] [diff] [review]
unregress Sunbird

r+ based on comment #4.

When committing, please remember we have a cross-commit policy and we are just in a release phase. There should be at least one clean 0.9pre nightly before checking in. It will probably be there Wednesday.

Comment 6

[Stefan [:stefanh]]

> When committing, please remember we have a cross-commit policy and we are just
> in a release phase. There should be at least one clean 0.9pre nightly before
> checking in. It will probably be there Wednesday.

OK, I'll land on trunk/branch after that then.

Comment 7

[Stefan [:stefanh]]

Landed this (the patch failed on branch, so I had to fix the file manually)

HEAD:
Checking in calendar/base/themes/pinstripe/preferences/preferences.css;
/cvsroot/mozilla/calendar/base/themes/pinstripe/preferences/preferences.css,v  <--  preferences.css
new revision: 1.6; previous revision: 1.5
done

MOZILLA_1_8_BRANCH:
Checking in calendar/base/themes/pinstripe/preferences/preferences.css;
/cvsroot/mozilla/calendar/base/themes/pinstripe/preferences/preferences.css,v  <--  preferences.css
new revision: 1.1.2.4; previous revision: 1.1.2.3
done