Closed Bug 421814 Opened 14 years ago Closed 14 years ago

Use HITheme to draw backgrounds for groupboxes

Categories

(Core :: Widget: Cocoa, enhancement)

x86
macOS
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta5

People

(Reporter: stefanh, Assigned: stefanh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We can actually use HITheme to draw the background of a groupbox instead of the current css (background-image with borders).
This seems to work and looks smoother compared with the current look. See Page Info (Security tab) for an example in Firefox. Note that the groupbox we simulate here is the one with the title positioned outside. This means that it's the xul groupbox-body that should have the "groupbox" look.
Attachment #308328 - Flags: review?(mano)
Attachment #308328 - Flags: review?(joshmoz)
Btw, this will regress prefpanels in Thunderbird/Sunbird, but I'll fix them in follow-ups (or here).
Status: NEW → ASSIGNED
Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

r=mano on the changes within browser/ and toolkit/.
Attachment #308328 - Flags: review?(mano) → review+
This is what Thunderbird will need if attachment #308328 [details] [diff] [review] lands on trunk.
Attachment #308328 - Flags: superreview?(roc)
Attachment #308328 - Flags: review?(joshmoz)
Attachment #308328 - Flags: review+
Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

+      HIThemeDrawGroupBox(&macRect, &gdi, cgContext, HITHEME_ORIENTATION);
+    }
+      break;

Put the break inside the brace

I could have sworn we had native theming for groupboxes on some platform, but I guess not.
Attachment #308328 - Flags: superreview?(roc) → superreview+
Attachment #308328 - Flags: approval1.9?
Attachment #308422 - Flags: review?(philringnalda)
(I'll open a new bug for the Sunbird fix)
Blocks: 422630
Comment on attachment 308422 [details] [diff] [review]
unregress Thunderbird (checked in)

r=philringnalda, thx
Attachment #308422 - Flags: review?(philringnalda) → review+
Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

a1.9+=damons
Attachment #308328 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
I'll check this in myself in a few minutes
Keywords: checkin-needed
Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

Landed with comment #5 addressed:

Checking in browser/themes/pinstripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.25; previous revision: 1.24
done
Checking in toolkit/themes/pinstripe/global/groupbox.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/groupbox.css,v  <--  groupbox.css
new revision: 1.4; previous revision: 1.3
done
Checking in gfx/public/nsThemeConstants.h;
/cvsroot/mozilla/gfx/public/nsThemeConstants.h,v  <--  nsThemeConstants.h
new revision: 1.27; previous revision: 1.26
done
Checking in layout/style/nsCSSKeywordList.h;
/cvsroot/mozilla/layout/style/nsCSSKeywordList.h,v  <--  nsCSSKeywordList.h
new revision: 3.104; previous revision: 3.103
done
Checking in layout/style/nsCSSProps.cpp;
/cvsroot/mozilla/layout/style/nsCSSProps.cpp,v  <--  nsCSSProps.cpp
new revision: 3.165; previous revision: 3.164
done
Checking in widget/src/cocoa/nsNativeThemeCocoa.mm;
/cvsroot/mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm,v  <--  nsNativeThemeCocoa.mm
new revision: 1.85; previous revision: 1.84
done
Attachment #308328 - Attachment description: Draw native background for groupbox → Draw native background for groupbox (checked in)
Comment on attachment 308422 [details] [diff] [review]
unregress Thunderbird (checked in)

Checking in mail/themes/pinstripe/mail/preferences/preferences.css;
/cvsroot/mozilla/mail/themes/pinstripe/mail/preferences/preferences.css,v  <--  preferences.css
new revision: 1.10; previous revision: 1.9
done
Attachment #308422 - Attachment description: unregress Thunderbird → unregress Thunderbird (checked in)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.