421814 - Use HITheme to draw backgrounds for groupboxes

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement)

Description

[Stefan [:stefanh]]

We can actually use HITheme to draw the background of a groupbox instead of the current css (background-image with borders).

Comment 1

[Stefan [:stefanh]]

Attachment: Draw native background for groupbox (checked in)

This seems to work and looks smoother compared with the current look. See Page Info (Security tab) for an example in Firefox. Note that the groupbox we simulate here is the one with the title positioned outside. This means that it's the xul groupbox-body that should have the "groupbox" look.

Comment 2

[Stefan [:stefanh]]

Btw, this will regress prefpanels in Thunderbird/Sunbird, but I'll fix them in follow-ups (or here).

Comment 3

[Asaf Romano (gone)]

Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

r=mano on the changes within browser/ and toolkit/.

Comment 4

[Stefan [:stefanh]]

Attachment: unregress Thunderbird (checked in)

This is what Thunderbird will need if attachment #308328 [details] [diff] [review] lands on trunk.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

+      HIThemeDrawGroupBox(&macRect, &gdi, cgContext, HITHEME_ORIENTATION);
+    }
+      break;

Put the break inside the brace

I could have sworn we had native theming for groupboxes on some platform, but I guess not.

Comment 6

[Stefan [:stefanh]]

(I'll open a new bug for the Sunbird fix)

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 308422 [details] [diff] [review]
unregress Thunderbird (checked in)

r=philringnalda, thx

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

a1.9+=damons

Comment 9

[Stefan [:stefanh]]

I'll check this in myself in a few minutes

Comment 10

[Stefan [:stefanh]]

Comment on attachment 308328 [details] [diff] [review]
Draw native background for groupbox (checked in)

Landed with comment #5 addressed:

Checking in browser/themes/pinstripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.25; previous revision: 1.24
done
Checking in toolkit/themes/pinstripe/global/groupbox.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/groupbox.css,v  <--  groupbox.css
new revision: 1.4; previous revision: 1.3
done
Checking in gfx/public/nsThemeConstants.h;
/cvsroot/mozilla/gfx/public/nsThemeConstants.h,v  <--  nsThemeConstants.h
new revision: 1.27; previous revision: 1.26
done
Checking in layout/style/nsCSSKeywordList.h;
/cvsroot/mozilla/layout/style/nsCSSKeywordList.h,v  <--  nsCSSKeywordList.h
new revision: 3.104; previous revision: 3.103
done
Checking in layout/style/nsCSSProps.cpp;
/cvsroot/mozilla/layout/style/nsCSSProps.cpp,v  <--  nsCSSProps.cpp
new revision: 3.165; previous revision: 3.164
done
Checking in widget/src/cocoa/nsNativeThemeCocoa.mm;
/cvsroot/mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm,v  <--  nsNativeThemeCocoa.mm
new revision: 1.85; previous revision: 1.84
done

Comment 11

[Stefan [:stefanh]]

Comment on attachment 308422 [details] [diff] [review]
unregress Thunderbird (checked in)

Checking in mail/themes/pinstripe/mail/preferences/preferences.css;
/cvsroot/mozilla/mail/themes/pinstripe/mail/preferences/preferences.css,v  <--  preferences.css
new revision: 1.10; previous revision: 1.9
done