423218 - Restart option does not appear for installs from the local filesystem

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Dave Townsend [:mossop]]

When installing an extension from the local disk by drag and drop into the app or by using the install button the restart button is not triggered.

Comment 1

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

See my related comment here:
https://bugzilla.mozilla.org/show_bug.cgi?id=414936#c44

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Since threading was removed from xpinstall it is now possible for a call to gEM.addDownloads to perform a complete install from the local filesystem in one hit. So in this case the install would complete, set gInstalling to false then addDownloads would return and gInstalling would get set to true. A simple reorder of setting the flag solves this.

Comment 3

[Tobias Fischer]

Just for the records: This affects SeaMonkey 2.0a1pre Trunk-Builds too. 

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Needed for toolkit apps like Thunderbird.

Comment 5

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.174; previous revision: 1.173
done

Comment 6

[pal-moz]

20080317_1734_firefox-3.0b5pre.en-US.win32.zip

fixed, thanks Mossop.

Comment 7

[Tobias Fischer]

Jupp, I can verify this, using SeaMonkey 2008031716 Tinderbox-Build. Thanks. 

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre ID:2008031904

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031806 Minefield/3.0b5pre ID:2008031806

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032003 Thunderbird/3.0a1pre ID:2008032003

Comment 9

[Tony Chung [:tchung]]

Added litmus test: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=5298