423282 - Achieve "web site" vs. "website" (vs. "site"?) consistency in SeaMonkey UI

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

This bug has been requested in bug 420730 comment #7 - we should try to become consistent wrt to "web site" vs. "website" (even vs. "site"?) in SeaMonkey UI at least.
Bug 385452 is a more general toolkit bug on this, BTW.

Comment 1

[Reed Loden [:reed]]

http://mashable.com/2010/04/16/ap-stylebook-website/
http://twitter.com/APStylebook/status/12296505018

Comment 2

[Robert Kaiser]

Attachment: suite parts

This should do everything in suite/ except Composer help, as that is better to be done together with a Composer patch. Also, I left about two cases of "site" in help where we're referring to toolkit string that don't have this change yet.

Comment 3

[Ian Neal]

(In reply to comment #2)
> Created an attachment (id=447103) [details]
> suite parts
> 
> This should do everything in suite/ except Composer help, as that is better to
> be done together with a Composer patch. Also, I left about two cases of "site"
> in help where we're referring to toolkit string that don't have this change
> yet.

Some changes also needed to pageInfo.properties
I've looked at the changes, will just do some testing of how some of them look.

Comment 4

[Ian Neal]

Comment on attachment 447103 [details] [diff] [review]
suite parts

The changes to Cookie Manager cause problems with the size of window (div.bannedservers.label and futureCookies.label)
r- for the moment

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> (From update of attachment 447103 [details] [diff] [review])
> The changes to Cookie Manager cause problems with the size of window
> (div.bannedservers.label and futureCookies.label)

Grr, now I can look into changing Cookie Manager while working on obsoleting it completely on a different thread (Data Manager) and have this patch bitrot in peace. :(

Comment 6

[Ian Neal]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 447103 [details] [diff] [review] [details])
> > The changes to Cookie Manager cause problems with the size of window
> > (div.bannedservers.label and futureCookies.label)
> 
> Grr, now I can look into changing Cookie Manager while working on obsoleting it
> completely on a different thread (Data Manager) and have this patch bitrot in
> peace. :(

You could always trim the patch to exclude the Cookie Manager bits (xul and help) or anything that will be changed when Data Manager lands.

Comment 7

[Robert Kaiser]

(In reply to comment #6)
> You could always trim the patch to exclude the Cookie Manager bits (xul and
> help) or anything that will be changed when Data Manager lands.

Not sure if it's more work to pull those out or to fix Cookie Manager. I guess I just hoped a tedious change like this would be easy. But then, we're at Mozilla, aren't we? :P

Comment 8

[Robert Kaiser]

Attachment: suite parts, v1.1

This patch updates cookie viewer to use a width in ch units (which is oriented on character widths instead of line heights like em), give it a bit more width in general, and make that description wrap if needed. I hope all that together should do things nicely.

Comment 9

[Ian Neal]

Comment on attachment 448572 [details] [diff] [review]
suite parts, v1.1

r=me with the pageInfo.properties changes made.

Comment 10

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/4396d376f799 with nits fixed.

Comment 11

[Robert Kaiser]

Ian, any suggestion what to do with "Publishing Site" as used in Composer?

Comment 12

[Robert Kaiser]

Actually, let's declare Composer a lost cause and mark this fixed.