423306 - use containing block (not parent inline) direction for deciding which side margin to ignore

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 328181 made us use the containing block direction instead of the element's direction when deciding which side margin to ignore for elements where one side margin has to be ignored due to overconstrained CSS2.1 10.3.3 calculations.  However, this fix didn't work right in the case where the block was inside an inline, because we (internally) treat the containing block as the :-moz-anonymous-block pseudo-element, whereas the spec says, I think, that the direction used should be that of the actual block.

I think this is the only reason we currently fail layout/reftests/box-properties/CSS21-t100303.xhtml .

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Possible solutions: 

 * make the :-moz-anonymous-block have a parent style context of its frame tree parent rather than its corresponding inline (which I think it has now)

 * make the nsHTMLReflowState code explicitly skip frames with these pseudo-elements

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This is more general than one of the above solutions and much simpler than the other.

Reftests pass (except zwnj-02.html, which always fails for me).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/e30af5899328

-> fixed (for 1.9.1)