462844 - Submenu appears at the bottom of the menu and can't be clicked

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[toutenkarton-bug]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre

When the cursor moves over the orange menu on the left, the submenu appears at the bottom of the menu. It's impossible to click because it desappears before.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.centrespiriteaugustinlesage.fr
2. Move the cursor on the orange menu on the left
3. See the result
Actual Results:  
The submenu appears at the bottom of the menu

Expected Results:  
With all the others browsers, the submenu appears on the right of the area you have selected.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed on Windows XP, latest trunk. This happened for the first time on 5 Jun 2008:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-06-05+01%3A00%3A00&enddate=2008-06-05+23%3A00%3A00

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

An Linux it regressed between 2008-06-05-02-mozilla-central and 2008-06-06-02-mozilla-central.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a regression from http://hg.mozilla.org/mozilla-central/rev/e30af5899328

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: partly simplified testcase

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: slightly more simplified

I removed one of the default display:none to show that there's an incremental layout bug here.

Note that things look much better if the <font> element is removed.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: mostly simple

This is also influenced by the quirks.css rule for dd not inside dl.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

> This is also influenced by the quirks.css rule for dd not inside dl.

Actually, the only thing influenced by that was my theory that there was an incremental layout bug.  Because of quirks.css, the initial value of 'display' is 'inline'.  The regression regressed 'block' and 'inline' differently, but I don't see any incremental layout differences once I account for that.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fully simplified, display:block

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fully simplified, display:inline

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So what's happening here is that InitAbsoluteConstraints uses the outer div as cbFrame.  This is correct for the use of cbFrame when testing direction, but wrong for the call to CalculateHypotheticalBox, since there's an anonymous block inside it that has more finely-divided line boxes.

So I think in the one caller that uses GetNearestContainingBlock, we actually now want two different answers in the two places that use the result of the function.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 349487 [details] [diff] [review]
patch

Full reftests pass on Linux, so requesting review.

You probably first want to have a look at bug 423306, which caused this.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 349487 [details] [diff] [review]
patch

Makes sense.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed in mozilla-central (and thus also on mozilla-1.9.1):
http://hg.mozilla.org/mozilla-central/rev/5d6db13efa26

Then backed out due to a Mac startup crash, whose underlying cause was actually
bug 466399:
http://hg.mozilla.org/mozilla-central/rev/2d0df3bbef22
http://hg.mozilla.org/mozilla-central/rev/acfda488bc5c

Then relanded, and thus again fixed in mozilla-central (and thus also on
mozilla-1.9.1):
http://hg.mozilla.org/mozilla-central/rev/0dfccaf1d58d

Comment 15

[Aakash Desai [:aakashd]]

verified FIXED (using attached testcases) on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090618 Shiretoko/3.5pre ID:20090618042848

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090610 Shiretoko/3.5pre ID:20090610031356

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre ID:20090618031143