423681 - Text events broken in text fields -- effective 3/15/08

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Go to http://www.google.com
Use accevent to watch events
Type letters 
TEXT_INSERTED events after the first get errors like the following:

TEXT_INSERTED	 Name=[Error getting string:80070057 - The parameter is incorrect.] Role=[Error getting role:80070057 - The parameter is incorrect.] State=[Error getting state:80070057 - The parameter is incorrect.] Attribs@@= NewText=

Comment 1

[Aaron Leventhal]

Broken for the first time in March 15 builds.

Comment 2

[Aaron Leventhal]

Regression range seems to point to bug 419416:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-14+00%3A00&maxdate=2008-03-15+08%3A00&cvsroot=%2Fcvsroot

Comment 3

[Aaron Leventhal]

Actually this was caused by security fix bug 401155. It's preventing a11y requests from being handled.

Comment 4

[Aaron Leventhal]

Attachment: Let a11y events through even during script unsafe times -- they are coming from win32

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*please* mark regressions as dependencies. Even if they are just suspected. It is very easy to loose track of them otherwise.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 310281 [details] [diff] [review]
Let a11y events through even during script unsafe times -- they are coming from win32

Looks ok.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

So are you sure that this code won't end up firing any events that content code can catch?

Comment 8

[Aaron Leventhal]

No, there might be a case where content code can catch it, but this a11y event only is fired when a screen reader or similar AT is running. I'll look into that issue but we need to get the accessibility builds going again.

Comment 9

[Aaron Leventhal]

Actually for content code to catch it, it would require either require that:
1) A Windows executable caught an MSAA event and in-process used an IAccessible method to perform an action or focus a node
2) The content had privileges to look at accessibility interfaces and catch events that way

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 310281 [details] [diff] [review]
Let a11y events through even during script unsafe times -- they are coming from win32

So I take it that's a "no"? If so looks fine to me, other than change NS_WARNING to NS_ERROR as we do want to assert.