Closed Bug 423813 Opened 17 years ago Closed 17 years ago

API is broken on php5

Categories

(addons.mozilla.org Graveyard :: API, defect)

Product:
addons.mozilla.org Graveyard
Component:
API
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clouserw, Assigned: clouserw)

Details

Attachments

(1 file)

fix error
1.07 KB, patch
laura
: review+
Details | Diff | Splinter Review
Attached patch fix error — — Splinter Review
Due to string vs. array stuff php5 is throwing this fatal error in the API: Cannot use string offset as an array in... The attached fixes the problem, but looking at the comment it sounds like this whole area is in flux. I'm not sure what the best result for the API is (the patch just passes an empty array) so I'm not going to commit it.
Attachment #310424 - Flags: review?
Attachment #310424 - Flags: review? → review?(laura)
Attachment #310424 - Flags: review?(laura) → review+
Patch is virtuous, committed in r11394.
Severity: normal → major
Keywords: push-needed
Assignee: nobody → clouserw
Keywords: push-needed
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Um, why is this fixed after AMO was pushed?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #2) > Um, why is this fixed after AMO was pushed? > The API is no longer broken on php5? Why is this reopened?
Updated SAMO last week after I reopened.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: