423814 - [10.5] Cannot change the input modes with Kotoeri By Ctrl+Shift+k/Ctrl+Shift+j/Ctrl+Shift+;

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is spun off from bug 411304.

Josh was fixed bug 411304, so, the ctrl key handling is correct, I think. However, on 10.5, the bug is still reproduced. (on 10.4 that is really fixed!)

The ctrl key down event is always sending to interpretKeyEvents, therefore, I have no idea for this. And I don't have 10.5 environment, unfortunately. So, I cannot debug this bug before 1.9 final...

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

In bug-jp 6078, I could get some feedback from a test.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=6078

On 10.5, if performKeyEquivalent returns NO, this bug can be fixed. However, we cannot do that. Therefore, we should call interpresKeyEvent at also performKeyEquivalent calls processKeyDownEvent after Ctrl key press event is handled.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 313416 [details] [diff] [review]
Patch v1.0

Probably, this approach may be wrong. I'm trying to find another approach...

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v2.0

This is better.

performKeyEquivalent is not called with Ctrl or Alt key pressed on 10.4, but on 10.5, that is called at that time. Therefore, if we don't call proccessKeyDown event from performKeyEquivalent on 10.5 too, we can fix this bug. This should be safer.

Comment 4

[Josh Aas]

Comment on attachment 313646 [details] [diff] [review]
Patch v2.0

This patch doesn't apply any more, you might want to look at the logic again too since bug 398514 changed a lot of things in our key handling.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v2.0.1

I don't need to change any logic. Only updating for the latest code.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

josh:

would you review this?

Comment 7

[Josh Aas]

One issue is that in google spreadsheets if you put text in a cell, select the cell, and hit ctrl-c, the copy is successful but there is a system beep. Not sure what the problem is with that, I'm going to be looking into beeping behavior soon and I'll keep this in mind.

Comment 8

[Josh Aas]

Comment on attachment 315394 [details] [diff] [review]
Patch v2.0.1

I don't think the beeping is a problem with this patch, it is another problem exposed by this patch on an OS version that it wasn't before. I will be looking into that problem today, we should go ahead with this patch.

>+  // Ctrl key and Alt key is used for shortcut keys for changing the input
>+  // source of input menu. performKeyEquivalent is not called on 10.4 at that
>+  // time, however, 10.5 calls this. Therefore, we should return NO for this
>+  // case. Cocoa will call keyDown like 10.4.

Please change this comment to:

Control and option modifiers are used when changing input sources in the input menu. We need to send such key events via "keyDown:", which will happen if we return NO here. This only applies to Mac OS X 10.5 and higher, previous OS versions just call "keyDown:" and not "performKeyEquivalent:" for such events.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v2.0.2

Thank you, josh.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Josh:

Do you think we should use another approach? If you think we should use this patch temporary, please request the a1.9.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316442 [details] [diff] [review]
Patch v2.0.2

a1.9=beltzner

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 14

[Steven Michaud [:smichaud] (Retired)]

Masayuki:

I can't seem to get Ctrl+Shift+J, Ctrl+Shift+K, Ctrl+Shift+L or
Ctrl+Shift+; to work in today's nightlies (Shiretoko, Namoroko or
Minefield).  Do you know what's going on?

I also can't get them to work in Safari ... so maybe I just don't know
how they're *supposed* to work.  Please let me know.

I do have Kotoeri turned on (in the International pref panel).  And
the shortcuts do show up in the Flags menu when one of the Kotoeri
input methods is chosen.

Thanks in advance!

Comment 15

[Steven Michaud [:smichaud] (Retired)]

Never mind, I figured it out.

For the Ctrl+Shift+J, Ctrl+Shift+K, Ctrl+Shift+L or
Ctrl+Shift+; keys to work, you have to

1) Have selected one of the Kotoeri input methods in the Flags menu

and

2) Have the keyboard focus in a text-input field.

Once this is true, these keyboard shortcuts allow you to switch
between the different Kotoeri input methods.

This does still work properly in current nightlies (all branches).

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #15)
> Never mind, I figured it out.
> 
> For the Ctrl+Shift+J, Ctrl+Shift+K, Ctrl+Shift+L or
> Ctrl+Shift+; keys to work, you have to
> 
> 1) Have selected one of the Kotoeri input methods in the Flags menu
> 
> and
> 
> 2) Have the keyboard focus in a text-input field.
> 
> Once this is true, these keyboard shortcuts allow you to switch
> between the different Kotoeri input methods.
> 
> This does still work properly in current nightlies (all branches).

ok, thanks.

The shortcut keys are processed by the *current* IME via interpretKeyEvents. When you choose another IME, of course it cannot process. When you don't set focus to editors, interpretKeyEvents has never called, so, you cannot use the shortcut keys.