424022 - Firefox 3 web services review for Spanish

Status: RESOLVED FIXED

Description

[Mic Berman]

tracking change for web services:
search plug in wikipedia, comments to come
keeping Creative Commons in search plug in list

Comment 1

[Mic Berman]

agreed in an IRC chat from Dec 18 that there would be no expected changes to existing services

terra.es is being investigated for mailto protocol, Guillermo, any progress there?

wp changed, at least the shortname changed to "Wikipedia (es)".

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Hi, well, Wikipedia has changed its name to "Wikipedia (es)" around 10 or 15 days ago.

[yesterday, making some test, I have a mistake,but with Pike i have discovered my error]

I have try to contact terra.es. In their contact page there is 3 things to contact them:

(a) Envío por correo postal a la siguiente dirección: Vía de las Dos Castillas, 33. Edificio Ática I. 28224 Pozuelo de Alarcón. Madrid.
This is my postal mail.

(b) Comunicación por medio de una llamada TELEFÓNICA DE ESPAÑA al número de teléfono:1004.
Telephone call

(c) Envío por correo electrónico a la siguiente dirección: [e-mail].
Email.

I have call to the phone number and nothing knows how to contact Terra.

I sent an email to this direction, and to [e-mail], which is listed in the page [1] and two directions don't exist (returning email).

So, should I insist in contact them?

[1] http://www.terra.es/info/copy.cfm -> Part 8 and Part 11.

Regards

Comment 3

[Mic Berman]

well, i believe we need them to turn on some server side things on their side. so we do need to find someone in terra :(

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Yes, in the email that I sent them, i wrote about webservices with mail protocol and a reference to the d.m.o document that describes it.

I'm going to find more emails in their webpage.

Note: We are on holidays, so maybe technical people in terra won't be until Monday 24.

Comment 5

[Axel Hecht [:Pike]]

Could you cvs remove the obsolete search xml files? In particular, google.xml, yahoo.xml, wikipedia.xml?

Comment 6

[Axel Hecht [:Pike]]

And reading Mic's comment here and in bug 415591 we should add creativecommons back to list.txt.

Please attach patches before checking in and request review from me, so that we keep a reference of what was changed why. Thanks.

Comment 7

[Mic Berman]

Guillermo - any word from Terra.es?

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Hi,

no response from Terra.es from [e-mail] or [e-mail] mail addresses.

So, I think we shouldn't include them as they have no answered my email.

I will attach patches in a while.

Comment 9

[Mic Berman]

apparently Pascal may have a contact through a friend. so let's see if we can get something in the next few days

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

Created attachment 312987 [details] [diff] [review]
Diffing for list.txt

Mmm, in the patch is not shown files deleted in the CVS:

actually, there is only:

drae.xml
eBay-es.xml
wikipedia-es.xml
yahoo-es.xml

terminal:

guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/searchplugins$ cvs -z3 diff >~/firefox-search.diff
cvs diff: Diffing .
cvs diff: google.xml was removed, no comparison available
cvs diff: wikipedia.xml was removed, no comparison available
cvs diff: yahoo.xml was removed, no comparison available
guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/searchplugins$ 


I don't know if this is all correct :S

Sorry for your extra-job for me

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 312987 [details] [diff] [review]
Diffing for list.txt

let's make an r- on this, and make a new patch.

Two issues, first, I think that list.txt has line ending issues. And it lacks a newline at the end of the file. I might be wrong about the line endings, but we'll see that with step 2.

Could you attach a patch created via

cvs -z3 diff -uN

? The -u switches to unified diffs, a format that is much more common within mozilla, and that I and others are used to read. The -N will include added and removed files in the patch. That should fix your worries about the contents of the patch.

Thanks

Comment 12

[Guillermo López :willyaranda (probably SLOW response)]

Created attachment 313051 [details] [diff] [review]
Unified patch for searchplugins changes for es-ES

Patch as Pike describe.

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 313051 [details] [diff] [review]
Unified patch for searchplugins changes for es-ES

r=me, please check in with a comment referencing both this bug and my review. Something like "bug 424022, add back creative commons, removing obsolete en-US plugins, r=[e-mail]" would work.

Comment 14

[Guillermo López :willyaranda (probably SLOW response)]

Done, check-in complete.

Comment 15

[Mic Berman]

now we only wait for Terra.es. Pascal has corresponded with them. (I can't reach spanish that well, so I'm not certain the latest). Pascal can you provide an update please

Comment 16

[Mic Berman]

update is that terra.es will not be ready for RC1 we'll take them in a later release. we can keep this bug open until then if you like but for RC1 we are completed AFAICT

Comment 17

[Axel Hecht [:Pike]]

Actually, let's close this bug with en-US defaults for fx 3.0 for protocol handlers.

Please open a different bug to track 3.0.x improvements, so that we can ship es-ES when all blockers are resolved.

Reference is http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/22ce813d31a5/reference/HEAD/es-ES/.