424240 - Tinder.config needs ENV var set for pdbstr.exe so that builds can be source indexed

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Adds one line to tinder-config.pl to set env variable

This patch adds a line to mozilla/tools/tinderbox-configs/firefox/win32/tinder-config.pl setting an environment variable (PDBSTR_PATH) to C:\Program Files\Debugging Tools for Windows\sdk\srcsrv\pdbstr.exe in order to allow the new source indexing code in symbolstore.py

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

see https://bugzilla.mozilla.org/show_bug.cgi?id=408134 for info about Source Server

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 310867 [details] [diff] [review]
Adds one line to tinder-config.pl to set env variable

You need to double up your slashes here ('c:\\Program files\\' etc), but otherwise this looks good.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: patch to add config for PDBSTR_PATH env var, now with doubled up slashes

Added double slashes for file path.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: One line to add PDBSTR_PATH to tinder-config.pl - with double slashes

This one has the correct line breaks and is really just one line of change.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: One line to add PDBSTR_PATH to tinder-config.pl - with double slashes

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311257 [details] [diff] [review]
One line to add PDBSTR_PATH to tinder-config.pl - with double slashes

a=beltzner

Comment 7

[(not currently active) Ted Mielczarek]

Checking in tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/win32/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.33; previous revision: 1.32
done

Comment 8

[(not currently active) Ted Mielczarek]

I landed this on the release branch while landing bug 428615.