428615 - Tinder.config needs ENV var set for SRCSRV_ROOT so that builds can be source indexed with the public cvs path

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Adds a SRCSRV_ROOT environment variable

This is a follow up to bug 424240 and is connected to bug 428518 where we discovered that the cvs_root on the tinderbox is a key-protected path and will therefore not work for the users of source indexed debug nightly builds.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 315233 [details] [diff] [review]
Adds a SRCSRV_ROOT environment variable

Looks good to me.

Comment 2

[(not currently active) Ted Mielczarek]

Although, we could use a comment there noting that both of these vars are for source server support. Also, we'll want to get this checked in on the 'release' branch as well.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: New Env Var with Comments as to why it's needed

So now there's a comment mentioning that these are for source server support :)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315627 [details] [diff] [review]
New Env Var with Comments as to why it's needed

a1.9=beltzner

Comment 5

[(not currently active) Ted Mielczarek]

I'll check this in tomorrow.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 315627 [details] [diff] [review]
New Env Var with Comments as to why it's needed

r+ to also land this on the release branch

Comment 7

[(not currently active) Ted Mielczarek]

Landed on trunk and release branch.