424517 - Icons on bookmarks toolbar should be always small

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Gabriele Best [:Gabri]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9b5pre) Gecko/2008032106 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9b5pre) Gecko/2008032106 Minefield/3.0b5pre

If I set "large icons" and then add a button (eg: reload button) to bookmarks toolbar it shows a large icon instead of a small one.

Screen: http://img172.imageshack.us/img172/5333/bhomekj1.png

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

This seems to be a duplicate of bug 171728, but I think that this needs to be reconsidered because of the small Home button on the BT, so this is a new situation. Confirming for now.

Comment 2

[Gabriele Best [:Gabri]]

To reproduce the bug:
1. First of all, open toolbar properties (right click on Navigation toolbar  and select properties);
2. Next, click on "Restore Default Set";
3. Then move home button and another button (eg.: refresh button) on bookmarks toolbar;
4. See that all icons on bookmarks toolbar are small;
5. Now set "Use small icons" and then unset it;
6. See that now it doesn't work anymore, not all the icons are small;

I think that now these patch https://bugzilla.mozilla.org/show_bug.cgi?id=404109 should be removed because all icons should be small, not only the home one.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

This does not block the final release of Firefox 3.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/587252c78f2f