Closed Bug 424532 Opened 17 years ago Closed 15 years ago

"Install script not found" error for SeaMonkey 1.x theme install from addons.mozilla.org

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: bmo.cec, Unassigned)

References

Details

Using SeaMonkey 1.1.8 and trying to install a new theme like : https://addons.mozilla.org/en-US/seamonkey/addon/4777 https://addons.mozilla.org/en-US/seamonkey/addon/4934 The installation begins and ends with the error message "Install script not found" and the theme is not installed.
AFAIK, current AMO uses a JS function for this that doesn't work with SeaMonkey 1.x and that's what breaks installation there. AMO probably does rely on apps having the new toolkit EM features, while our 1.x versions suck and are still based on xpfe/xpinstall for that.
Component: Add-ons → Public Pages
OS: Windows XP → All
QA Contact: add-ons → web-ui
Hardware: PC → All
So, can't they revise the JS function so that it will work with SeaMonkey 1.x? What is the point of providing access to the themes if the install will not work? JS similar to this will work locally. Adapt it so that it fits into AMO scheme of things. --- <script type="text/javascript"> function installMe(name,file,version) { InstallTrigger.installChrome(InstallTrigger.SKIN,file+'.jar',name+"/"+version) } </script> <script type="text/javascript" src="styleswitcher.js"></script> </head> <body> <div class="kop">Nautipolis 1.832 1832-052306</div> <div class="toolbar"> <a class="button" href="#" onclick="installMe('Nautipolis', 'Nautipolis_1832', '1.83')">Install</a> </div> --- (Basically slightly modified code that used to be found on Alfred Kayser's website.) Bug 416349 may be a DUP.
Interestingly, downloads of themes from the Themer site work OK. Downloads of Themes from the Sea Monkey site do not. I'm not a programmer, but I send this in the hope that it might pin-point the problem.
It's definitely an AMO problem, probably only since AMO 3.2+ but maybe starting even earlier. AMO should use something like this installation snippet from http://themes.mozdev.org/themes/orbit.html for SeaMonkey 1.x: javascript:void(InstallTrigger.installChrome(InstallTrigger.SKIN, 'http://downloads.mozdev.org/themes/themes/1_8/orbit-1_8f1-MiK.jar', 'Orbit 3+1 MiK [u] Trunk')) But actually, AMO is probably using the mechanisms that only work with toolkit-based applications (like Firefox or SeaMonkey 2) for all applications, which makes them fail in 1.x
Summary: SeaMonkey 1.1.x Themes can't be installed. Error message "Install script not found" → "Install script not found" error for SeaMonkey 1.x theme install from addons.mozilla.org
We stopped using the installChrome method because it does not take in a hash to verify the download, and was deemed insecure. I guess we can look at bringing it back for only SeaMonkey themes.
fligtar: Yes, I think bringing it back for SeaMonkey themes, ideally only when "SeaMonkey/1." is in the UA string of the visitor, would be a good solution for this.
I have also gotten the message "Install script not found" with SeaMonkey 1.1.9. I'm not a programmer, so I have no clue how to fix it.
Does this depend on bug 439980 (version checking for SeaMonkey)?
AMO guys, can we do something about that?
Depends on: 498825
with 1.1.17 I got the "Install script not found" when I installed German Dictionary and Addblock Plus, but after restarting SeaMonkey, the add-ons where available. *NOW* with 1.1.18 I got the "Install script not found" but no add-ons are added! *BAD* it is a bad idea not to let me download the add-ons xpi files from the add-on server, because I have to install SeaMonky and add-ons on various computers with only modem connection to the net.
Karl Heiz Hinterseeer: This bug is about *themes* only, your problems are add-ons that are NOT compatible with SeaMonkey 1.1.18 at all in their newest versions and for both you can select older versions that install and work with SeaMonkey 1.1.18.
If the problem is incompatible themes, then either: 1. the incompatible themes should not be displayed. What is happening is called "tantalising". 2. the themes should be marked with the highest version number with which they are compatible. From the point of view of the average user, the install just failed for no reason. She has no reason to suspect the problem is old incompatible themes.
The case of incompatible themes is also not what this bug is about, the solution on the AMO side is the version check requested in another bug, the solution of the SeaMonkey side is to get rid of the badly designed old extension model of 1.x and move to 2.x where the problem is solved. This bug is about not being able to install _compatible_ themes in SeaMonkey 1.x from AMO due to the removal of the installTrigger method.
Priority: -- → P3
Target Milestone: --- → Future
1.x has been EOLed, so let's just close this. A pity that we couldn't get it solved when it was important, but it shouldn't matter any more, let's make things better in the future.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.