Closed Bug 424694 Opened 16 years ago Closed 16 years ago

Scrollbar decoration (the tiny set of 4 lines) is misaligned

Categories

(Toolkit :: UI Widgets, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ben.r.xiao, Assigned: kliu)

References

Details

(Keywords: polish, regression)

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre Firefox/2.0.0.12

When you compare the scrollbars in XP and  the scrollbars in Firefox, the decoration in the middle of the Firefox scrollbar (the tiny indented 4 lines) is shifted to the right in vertical positions and down in horizontal positions,

Reproducible: Always

Steps to Reproduce:
1.Open Minefield
2.Open file explorer
3.Compare scrollbars
Actual Results:  
The decoration in Firefox scrollbars look off-center compared to XP's

Expected Results:  
Scrollbars should match.
Bug 429975 has screenshots.
Component: Theme → Widget: Win32
Product: Firefox → Core
QA Contact: theme → win32
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
This problem occurs only if the difference between the width of the thumb button (default is 17px in Luna) and the width of the gripper (default is 8px in Luna) is odd.

Windows will distribute the space such that left/top will get floor(n/2) and right/bottom will get floor(n/2)+1 if n%2=1.  However, Gecko does the opposite, and left/top gets floor(n/2)+1 and right/bottom gets floor(n/2).

This is the cause of a number of other minor inconsistencies in Gecko's UI appearance on Windows (such as the menu text being shifted 1px down in Gecko for themed Vista menus), but it's usually not noticeable without pixel-counting.  But here, it is...
Component: Widget: Win32 → XUL Widgets
Flags: wanted1.9.1?
Flags: wanted1.9.0.x?
Product: Core → Toolkit
QA Contact: win32 → xul.widgets
Version: Trunk → 1.9.0 Branch
Attached patch fix (obsolete) — Splinter Review
This fixes the problem in the case where width(thumb)-width(grip) is odd, and it does not break the case where it is even.
Assignee: nobody → kliu
Status: NEW → ASSIGNED
Attachment #325132 - Flags: review?(gavin.sharp)
The regression here is a part of the fallout from bug 177805, and is similar to bug 369882 (the solution that was adopted there appears to be similar).
Keywords: polish, regression
(In reply to comment #6)
> is similar to bug 369882
> 

...and bug 428817, too.
Whiteboard: [has patch][needs review gavin]
Depends on: 448704
Flags: wanted1.9.1?
Flags: wanted1.9.0.x?
Whiteboard: [has patch][needs review gavin]
Version: 1.9.0 Branch → Trunk
Comment on attachment 325132 [details] [diff] [review]
fix

Let's not use a CSS hack if we could avoid it; this bug will be fixed by bug 448704.
Attachment #325132 - Attachment is obsolete: true
Attachment #325132 - Flags: review?(gavin.sharp)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: