424764 - Error: selectedFolders[0]/msgFolder is undefined when opening the File menu of the standalone msg window

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Open an .eml file in the standalone message window (I used on attached .eml from an email), open the File menu

in IsAccountOfflineEnabled():
Error: selectedFolders[0] is undefined 
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2146

Also after overing over "New ->", in menu_new_init():
Error: msgFolder is undefined
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 52

Pretty sure this is a fairly recent regression. Didn't look to closely, but presumably some menu items don't work correctly due to this.

Comment 1

[Magnus Melin [:mkmelin]]

Partly this was a regression from bug 416666 (attachment 303943 [details] [diff] [review]), partly due to premature optimization. 

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Fixes:
 - msgHdr is null for .eml files
 - make the standalone msg window version of GetSelectedMsgFolders not return an array with wrong length, the 3pane version returns a 0-size array, so doing it here too
 - function checkMsgHdrPropertyIsNot looks to be unused now after the patch in my previous comment

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 316191 [details] [diff] [review]
proposed fix

Looks good, thanks. r=philringnalda

Comment 4

[Magnus Melin [:mkmelin]]

Checking in mail/base/content/mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <--  mailWindowOverlay.js
new revision: 1.197; previous revision: 1.196
done
Checking in mail/base/content/messageWindow.js;
/cvsroot/mozilla/mail/base/content/messageWindow.js,v  <--  messageWindow.js
new revision: 1.63; previous revision: 1.62
done

->FIXED