424816 - Update Mochitest Scriptaculous Test Suite to 1.8.1

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[John Resig]

The test suite that we have for Scriptaculous is out of date, at this point, it should be upgraded to the latest version: 1.8.1.

Comment 1

[Tim Riley [:timr]]

Heather-  This is what you are working on next, right?

Comment 2

[cmtalbert]

Attachment: Patch with updated scriptaculous

This patch brings us up to Scriptaculous 1.8.1.  This time, I found three tests that are no longer working, and one that is.

Tests Disabled last time:
* ajax_autocompleter_test.html
* slider_test.html
* bdd_test.html

This time, I found that the bdd_test.html worked without causing any issues.  But a new test has started failing.  This patch has the following tests disabled:
* ajax_autocompleter_test.html
* slider_test.html
* ajax_inplaceeditor_test.html

All the other tests run in the test.  I'll ask for review once I test it on linux to be sure it's ok there.

Comment 3

[cmtalbert]

Attachment: Updated patch

I found a gotcha: the previous patch was missing two files.  Those have been added to this version.  I tested this version on Mac OS X and windows and it works, all tests pass, except for those mentioned above, which I'll open follow-on bugs for.

Comment 4

[cmtalbert]

Rob C: are you the proper person to review this, or should it be Rob Sayre?

Comment 5

[Rob Campbell [:rc] (:robcee)]

I've reviewed them in the past, though I'm not sure I'm the *correctest* person to do it at this point. Rob Sayre or Jeff Walden would be preferred.

That said, given the size of this patch, a line-by-line review is going to be time-consuming. Has this been tested in your local environment? How many platforms? Any changes to build code (i.e., makefiles)?

Comment 6

[Rob Campbell [:rc] (:robcee)]

hey Clint, are you still waiting on a review from me for this?

How much has this patch been tested locally and on what platforms?

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 327197 [details] [diff] [review]
Updated patch

this patch is probably pretty stale. Clearing review flags. Rerequest if we need a review for this. Also, consider updating bug status.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Please feel free to open a new task issue, if there is a need to integrate a new test suite.
https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing is perhaps a better product fit to file a similar issue.