If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Empty user level extension folder (\AppData\Roaming\Mozilla\Extensions\{ec8030f7-c20a-464f-9b0e-13a3a9e97384}) should be removed on uninstall

VERIFIED FIXED in Firefox 3

Status

()

Firefox
Installer
--
minor
VERIFIED FIXED
10 years ago
a year ago

People

(Reporter: AndrewM, Assigned: rstrong)

Tracking

Trunk
Firefox 3
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield nightly Firefox/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield nightly Firefox/3.0b5pre

Spinoff from bug 407008.

Currently, the empty user level extension extension folder (at C:\Users\[USERNAME]\AppData\Roaming\Mozilla\Extensions\{ec8030f7-c20a-464f-9b0e-13a3a9e97384}
 on Vista) is left behind on uninstall; this should be removed.

Reproducible: Always
(Reporter)

Updated

10 years ago
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Created attachment 315165 [details] [diff] [review]
patch rev1

Remove %APPDATA%\Mozilla\{ec8030f7-c20a-464f-9b0e-13a3a9e97384} recursively and remove %APPDATA%\Mozilla if it is empty when removing personal data
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #315165 - Flags: review?(benjamin)

Comment 2

10 years ago
I don't understand. Comment0 has appdata/roaming/Mozilla/Extensions/{ec...}
the patch has appdata/Mozilla/{ec...}

Who created this directory? What does it have in it?
Created attachment 315171 [details] [diff] [review]
patch rev2

It had the wrong path

It was added as part of bug 311008
Attachment #315165 - Attachment is obsolete: true
Attachment #315165 - Flags: review?(benjamin)

Comment 4

10 years ago
Comment on attachment 315171 [details] [diff] [review]
patch rev2

If an external app installs an extension to this directory, I don't think we should be removing it... or am I missing something?
I considered going with just removing it when empty and can change it accordingly. The concern I have is that if the user experiences problems with the extension and expects cleaning personal data to fix it.
Created attachment 315175 [details] [diff] [review]
patch rev3 - only remove when empty
Attachment #315171 - Attachment is obsolete: true
Attachment #315175 - Flags: review?(benjamin)

Updated

10 years ago
Attachment #315175 - Flags: review?(benjamin) → review+
Comment on attachment 315175 [details] [diff] [review]
patch rev3 - only remove when empty

Drivers, this is a simple / safe fix that removes empty directories when personal data is removed during install. IIRC the removal of empty directories is one of the requirements on the PRD so I am asking for a1.9.
Attachment #315175 - Flags: approval1.9?
Comment on attachment 315175 [details] [diff] [review]
patch rev3 - only remove when empty

a1.9=beltzner
Attachment #315175 - Flags: approval1.9? → approval1.9+
Checked in to trunk

Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstaller.nsi
new revision: 1.20; previous revision: 1.19
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041506 Minefield/3.0pre. I verified by testing both uninstalling and checking the box to remove the user directory as well as not checking the box with extensions installed.
Status: RESOLVED → VERIFIED
See Also: → bug 1254078
You need to log in before you can comment on or make changes to this bug.