If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

fail to release HTML element in HTMLContentSink::ProcessScriptTag

RESOLVED WORKSFORME

Status

()

Core
HTML: Parser
P3
normal
RESOLVED WORKSFORME
18 years ago
13 years ago

People

(Reporter: Chris Waterson, Assigned: jst)

Tracking

({mlk})

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3-], URL)

(Reporter)

Description

18 years ago
See patrick's leak root test. This is a real obvious one, I think. At

http://lxr.mozilla.org/mozilla/source/layout/html/document/src/nsHTMLContentSink.cpp#4560

you create an HMTL element with a bare pointer (luddite!), and then drop it on
the floor about ten lines later. Use a nsCOMPtr!
(Reporter)

Updated

18 years ago
Keywords: mlk
(Reporter)

Comment 1

18 years ago
Well, never mind. I was wrong. This code doesn't leak here (it still leaks!) but
it's not in the method I thought it was. And you're still a luddite ;-).

Comment 2

18 years ago
This code was written before nsCOMPtrs were even a twinkle in anyone's eye, 
sonny boy. MLK, so I'll put it high on the priority list.
Status: NEW → ASSIGNED

Updated

18 years ago
Keywords: nsbeta3

Updated

17 years ago
Whiteboard: [nsbeta3+]

Comment 3

17 years ago
Re-assigning bug to jst as per our decision in yesterday's bug triage meeting.
Status: ASSIGNED → NEW

Comment 4

17 years ago
Really re-assigning...
Assignee: vidur → jst

Comment 5

17 years ago
Marking nsbeta3-.
Whiteboard: [nsbeta3+] → [nsbeta3-]
(Assignee)

Comment 6

17 years ago
This bug has been marked "future" because the original netscape engineer
working on this is over-burdened. If you feel this is an error, that you or
another known resource will be working on this bug,or if it blocks your work
in some way -- please attach your concern to the bug for reconsideration.
Status: NEW → ASSIGNED
Target Milestone: --- → Future

Comment 7

17 years ago
updated qa contact.
QA Contact: janc → bsharma

Updated

16 years ago
Blocks: 92580

Updated

16 years ago
QA Contact: bsharma → moied

Updated

16 years ago
No longer blocks: 92580
Is this still an issue?  It's not clear what this leak root test did, and I've
not seen script elements leaking in leak logs....
Going out on a limb an marking worksforme.  As existing this bug isn't really
useful...
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.