42501 - fail to release HTML element in HTMLContentSink::ProcessScriptTag

Status: RESOLVED WORKSFORME

(Core :: DOM: HTML Parser, defect, P3)

Description

[Chris Waterson]

See patrick's leak root test. This is a real obvious one, I think. At

http://lxr.mozilla.org/mozilla/source/layout/html/document/src/nsHTMLContentSink.cpp#4560

you create an HMTL element with a bare pointer (luddite!), and then drop it on
the floor about ten lines later. Use a nsCOMPtr!

Comment 1

[Chris Waterson]

Well, never mind. I was wrong. This code doesn't leak here (it still leaks!) but
it's not in the method I thought it was. And you're still a luddite ;-).

Comment 2

[vidur (gone)]

This code was written before nsCOMPtrs were even a twinkle in anyone's eye, 
sonny boy. MLK, so I'll put it high on the priority list.

Comment 3

[Nisheeth Ranjan]

Re-assigning bug to jst as per our decision in yesterday's bug triage meeting.

Comment 4

[Nisheeth Ranjan]

Really re-assigning...

Comment 5

[Nisheeth Ranjan]

Marking nsbeta3-.

Comment 6

[Johnny Stenback (:jst)]

This bug has been marked "future" because the original netscape engineer
working on this is over-burdened. If you feel this is an error, that you or
another known resource will be working on this bug,or if it blocks your work
in some way -- please attach your concern to the bug for reconsideration.

Comment 7

[bsharma]

updated qa contact.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Is this still an issue?  It's not clear what this leak root test did, and I've
not seen script elements leaking in leak logs....

Comment 9

[Boris Zbarsky [:bzbarsky]]

Going out on a limb an marking worksforme.  As existing this bug isn't really
useful...