Closed
Bug 425010
Opened 17 years ago
Closed 17 years ago
checkbox text missing, feed subscription controls do nothing
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: bugmozz, Assigned: asaf)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
12.03 KB,
image/jpeg
|
Details | |
|
1.54 KB,
patch
|
asaf
:
review+
mconnor
:
approval1.9b5+
|
Details | Diff | Splinter Review |
screenshot
OK: 20080324_0438_N_firefox-3.0b5pre.en-US.win32.zip
NG: 20080324_0715_firefox-3.0b5pre.en-US.win32.zip
maybe bug 360529 cause this.
Summary: []checkbox text is missing. → [Feed Preview] checkbox text is missing.
|
||
Comment 3•17 years ago
|
||
Yes, looks like it might be bug 360529. CC-ing Mano
Depends on: 360529
Flags: blocking-firefox3?
|
||
Updated•17 years ago
|
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Summary: [Feed Preview] checkbox text is missing. → checkbox text missing, feed subscription controls do nothing
|
||
Comment 6•17 years ago
|
||
Happens on Mac as well, get this error in the console: Error: uncaught exception: [Exception... "'[JavaScript Error: "stringlabel is not defined" {file: "file:///Users/marcia/Desktop/LatestTrunk/Minefield.app/Contents/MacOS/components/FeedWriter.js" line: 777}]' when calling method: [nsIFeedWriter::init]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://browser/content/feeds/subscribe.js :: SH_init :: line 47" data: yes]
|
|
||
Comment 7•17 years ago
|
||
Connor: need an assignee, stat. :(
Hardware: PC → All
Target Milestone: --- → Firefox 3 beta5
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → mano
|
|
Assignee | |
Comment 8•17 years ago
|
||
This has r=gavin over irc.
Attachment #311676 -
Flags: review+
Attachment #311676 -
Flags: approval1.9b5?
|
|
Assignee | |
Comment 9•17 years ago
|
||
Attachment #311676 -
Attachment is obsolete: true
Attachment #311678 -
Flags: review+
Attachment #311678 -
Flags: approval1.9b5?
Attachment #311676 -
Flags: approval1.9b5?
|
||
Comment 10•17 years ago
|
||
Comment on attachment 311676 [details] [diff] [review]
patch
> stringlabel = "alwaysUseForAudioPodcasts";
> break;
> }
>
> this._contentSandbox.checkbox = checkbox;
>- this._contentSandbox.label = this._getFormattedString(stringlabel, [handlerName]);
>+ this._contentSandbox.label = this._getFormattedString(stringLabel, [handlerName]);
Um, that means you'll use the generic feed label for audio/video podcasts as well as generic feeds, since the switch will just be setting a different, undeclared variable with a lowercase l.
Attachment #311676 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•17 years ago
|
Attachment #311676 -
Attachment is obsolete: true
|
||
Comment 12•17 years ago
|
||
Comment on attachment 311678 [details] [diff] [review]
two more places
a=mconnor, please land ASAP
Attachment #311678 -
Flags: approval1.9b5? → approval1.9b5+
|
|
Assignee | |
Comment 13•17 years ago
|
||
mozilla/browser/components/feeds/src/FeedWriter.js 1.55
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 14•17 years ago
|
||
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008032704 Minefield/3.0pre.
Status: RESOLVED → VERIFIED
|
|
||
Updated•16 years ago
|
Flags: in-testsuite?
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•