425590 - "View Bug Activity" is broken

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13
Build Identifier: 

When I accesed view activity of bug, I recieved


Reproducible: Always

Steps to Reproduce:
1.Show bug
2.Click view Bug activity
3.
Actual Results:  
-------
Software error:

DBD::mysql::db selectall_arrayref failed: Column 'bug_id' in field list is ambiguous [for Statement "
        SELECT COALESCE(fielddefs.description, CONCAT(bugs_activity.fieldid, '')), fielddefs.name, bugs_activity.attach_id, DATE_FORMAT(bugs_activity.bug_when, '%Y.%m.%d %H:%i:%s'), bugs_activity.removed, bugs_activity.added, profiles.login_name, bug_id
          FROM bugs_activity
               LEFT JOIN attachments 
                   ON attachments.attach_id = bugs_activity.attach_id
     LEFT JOIN fielddefs
            ON bugs_activity.fieldid = fielddefs.id
    INNER JOIN profiles
            ON profiles.userid = bugs_activity.who
         WHERE bugs_activity.bug_id = ?
               
               AND COALESCE(attachments.isprivate, 0) = 0
      ORDER BY bugs_activity.bug_when"] at /data/www/bugzilla.mozilla.org/Bugzilla/Bug.pm line 1639
	Bugzilla::Bug::GetBugActivity(394473) called at /data/www/bugzilla.mozilla.org/show_activity.cgi line 91
	ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_show_activity_2ecgi::handler('Apache2::RequestRec=SCALAR(0xa61d77c)') called at /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 204
	eval {...} called at /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 204
	ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x95feefc)') called at /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/ModPerl/RegistryCooker.pm line 170
	ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x95feefc)') called at /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/ModPerl/Registry.pm line 31
	ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0xa61d77c)') called at /data/www/bugzilla.mozilla.org/mod_perl.pl line 97
	Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0xa61d77c)') called at -e line 0
	eval {...} called at -e line 0

For help, please send mail to the webmaster ([e-mail]), giving this error message and the time and date of the error. 

Expected Results:  
Bug's activity is displayed

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch User.pm

This is deployed in production already, seems to work.

Comment 2

[Dave Miller [:justdave]]

Masahiro: working for you, too?

Comment 3

[Dave Miller [:justdave]]

nope, was still busted.  Looks like we have the same query in Bug.pm, too, having the same problem.  After I already committed the first patch. :)

modified Bugzilla/User.pm
Committed revision 5177.

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch Bug.pm

Comment 5

[Dave Miller [:justdave]]

modified Bugzilla/Bug.pm
Committed revision 5178.

Comment 6

[Dave Miller [:justdave]]

everyone on irc is telling me this is fixed now. :)  yay

Comment 7

[Masahiro YAMADA]

Now I can see "View Bug Activity" of this bug.
--> Verified