Closed Bug 425636 Opened 14 years ago Closed 14 years ago

Creating an attachment does bad comment wrapping

Categories

(Bugzilla :: Attachments & Requests, defect)

3.0.3
defect
Not set
minor

Tracking

()

RESOLVED INVALID

People

(Reporter: bbaetz, Unassigned)

References

Details

(Keywords: regression)

Split off from bug 425606, which is a separate issue.

Creating an attachment and adding a comment has busted wrapping. Max's comment in that bug is:

> Well, the only difference I can see is that the attachment screen's textarea
> has wrap="soft", which it probably shouldn't have.

See attachment 312212 [details] for a screenshot
Flags: blocking3.2?
Flags: blocking3.0.4?
I cannot reproduce, neither in Bugzilla 3.1.4pre nor in 3.0.4pre.
OS: Linux → All
Hardware: PC → All
Summary: Creating an attachment breaks wrapping → Creating an attachment does bad comment wrapping
Depends on: 425606
I cannot reproduce, neither. (in Bugzilla 3.1.3+ / trunk) I think it's something a customization problem.
Does the text wrapping width (in CSS) is larger than Text::Wrap's one?

Defaults in Bugzilla-tip is as the followings
* Bugzilla/Constants.pm : use constant COMMENT_COLS => 80;
* wrap_comment override in templates : none (use the default : COMMENT_COLS)
* text width in standard/global.css : .bz_comment_text {width: 50em; }
Looking at the issue Shaver was complaining about, that comment is dated in Feb. 

Shaver, was this a new issue, or an existing one?
New as of the BMO upgrade.  I don't see the problem if I switch away from the ProFontX 9pt font I use for fixed-width, fwiw.
(In reply to comment #4)
> New as of the BMO upgrade.  I don't see the problem if I switch away from the
> ProFontX 9pt font I use for fixed-width, fwiw.

  That's the problem.

  Old browsers are unable to wrap <pre> text on the client side, and Perl is unable to correctly wrap multi-byte text. So our compromise was to wrap single-byte text on the Perl side, and add a (slightly larger) wrap width on the client side for comments, which would handle multi-byte text.

  I'd like to get rid of the server-side wrap, but we still have to support browsers that can't do white-space: pre-wrap or its various browser-specific equivalents.

  If you modify the CSS "width" of .bz_comment_text in your userContent.css, that should fix it for you.
This is not a blocker--it's only triggered by shaver's custom fonts, and he can work around it on his side. In fact, I'm not even sure it counts as a bug.
Severity: normal → minor
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: blocking3.2?
Flags: blocking3.2-
Flags: blocking3.0.4?
Flags: blocking3.0.4-
Resolution: --- → INVALID
If I increase my page size by 1 in Firefox 3 using CTRL-+, I run into this issue as well (see bug 485165 / bug 485062).
You need to log in before you can comment on or make changes to this bug.