Closed Bug 485062 Opened 15 years ago Closed 15 years ago

standard skin CSS causes comments to be wrapped twice

Categories

(Bugzilla :: User Interface, defect)

3.0.6
x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED DUPLICATE of bug 436189

People

(Reporter: hull, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.7) Gecko/2009030503 Fedora/3.0.7-1.fc10 Firefox/3.0.7
Build Identifier: 

template/en/default/bug/comments.html.tmpl applies the wrap_comment filter to comments, which causes them to be wrapped to 80 characters (set by COMMENT_COL, defined in Bugzilla/Constants.pm).

But skins/standard/global.css sets the .bz_comment_text width to 50em.  For me, with my Firefox 3.0.7 install under Fedora 10, this causes comments to be wrapped twice.  A long comment line looks like this:

Blah blah blah blah blah.  Blah blah blah.  Blah blah blah
blah blah
blah blah blah.  Blah blah blah blah blah blah blah blah.
blah blah blah.

That is, the wrap_comment wraps the comment to 80 characters, but this is, for me, wider than 50em, so the browser wraps it again.


Reproducible: Always




Changing skins/standard/global.css to set .bz_comment_text width from 50em to 60em fixes the problem for me.
I forgot to write, we are using Bugzilla 3.0.6, but I checked the source for the latest development version, 3.3.3, and it appears that there hasn't been any change that would affect this bug.
Version: unspecified → 3.0.6
This is only possible if you've set a custom font in your web browser or in your Bugzilla CSS.

The CSS wrapping exists to wrap CJK characters and other languages that lack spaces. (Perl cannot correctly wrap those languages, and CSS cannot correctly and exactly wrap English the way we want it to.)
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
> This is only possible if you've set a custom font in your web browser or in
> your Bugzilla CSS.

I believe that this assertion is wrong.  The "global.css" that my browser downloaded is identical to the one distributed with bugzilla 3.0.8.  Firebug indicates that this global.css file is the one that is setting the width and font-family property for the comment text.  The font-family is specified by global.css as "monospace".  It appears that X (font-config) is mapping monospace to "DejaVu Sans Mono", as specified by /etc/fonts/conf.avail/60-latin.conf ("fc-match monospace" returns 'DejaVuLGCSansMono.ttf: "DejaVu LGC Sans Mono" "Book").  I think that all of these things are the defaults for my operating system, Fedora 10.

I've fixed the problem for myself by overriding the .bz_comment_text width property in my personal userContent.css file.  Thank you for the explanation of why a width property is specified for .bz_comment_text.  I think that there might be a small minority of people whose default monospace font is a little wider than average who would benefit from a small increase in the width property.  It really does adversely affect the readability of the comment when it is doubly wrapped as I described above.
I wonder if that's a duplicate of bug 425636, despite it mentions attachments.
(In reply to comment #5)
> I wonder if that's a duplicate of bug 425636, despite it mentions attachments.

It is definitely the same issue as described in bug 425636 comment 5.

By the way, quoting from my (duplicate) bug:

> This happens because a comment field has a "white-space: pre-wrap" style. I
> recommend that as a fix, this be changed to "white-space: pre". 

> Or, to make the containing element wider, to fit to the width of the page.

~Laurens
And, to make clear, I am not using a custom font, as is asserted in comment 2.

I have simply increased my page size by 1 in Firefox 3 using CTRL-+, so that it is better readable on my 120dpi screen.

So, if the bug was put on INVALID per comment 2, then I request it be reopened.
I talked to the Bugzilla administrator at our site, and it turns out that he increased COMMENT_COLS in Bugzilla/Constants.pm (from 80 to 100), and so my problem is a duplicate of Bug 436189.

Given that that bug is still open, I will put further comments there.
Resolution: INVALID → DUPLICATE
You need to log in before you can comment on or make changes to this bug.