425657 - Add-on metadata de-utf-8-ed in extensions.rdf

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Axel Hecht [:Pike]]

Attachment: fx3 add-on details screenshot

It seems that the meta data for the German dictionary is busted, see attached screen shot.

Robert says that the title is OK locally, so I wonder if this broke in the AMO update. It looks like the UTF-8 string for "Wörterbuch" got interpreted as ASCII or latin-1 at one point.

Comment 1

[Axel Hecht [:Pike]]

Oops, sorry.

Clearly a Toolkit EM bug.

In my profile, it's encoded correctly in extensions/[e-mail]/install.rdf, but brokenly in extensions.rdf.

So it's somewhere in the extension registration code.

This should block Firefox 3.

Comment 2

[Robert Kaiser]

Yes, install.rdf is correct UTF8.

I'm also convinced this is a bug in trunk EM, not in AMO. While downloading and in the popup that asks for installation, the German text (coming from AMO) is correct, only once we read the install.rdf the title is shown as if we'd display/read the UTF8 as ISO-8859-1.

The same is true for the Belarusian dictionary (just to have a second testcase), and I'm also seeing this is SeaMonkey trunk (using the same toolkit EM).

Comment 3

[Dave Townsend [:mossop]]

I'll do some investigation to figure out what is going on here.

Comment 4

[Dave Townsend [:mossop]]

This is a regression from bug 424107. We should block on this as it will mess up any extension information containing multi-byte characters. Have a unit test ready and the fix will be reasonably easy to implement, just deciding on the best course of action.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This correctly handles character encodings in the install manifest. There are a few different ways to achieve this, none of them ideally suited to what we want (sychronous behaviour with the rdf not ending up in the datasource cache). The approach I have taken is to get a streamlistener from the rdf parser to push data to. Then simply call it repeatedly as long as there is data remaining in the file input stream.

Added in some exception handling which will show up as a malformed install.rdf and then returns no data.

The testcase install.rdf looks a little odd in the patch because it is saved with windows line endings which is something else I have heard is broken and wanted to test.

Comment 6

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.285; previous revision: 1.284
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug425657.js,v
done
Checking in toolkit/mozapps/extensions/test/unit/test_bug425657.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug425657.js,v  <--  test_bug425657.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug425657/install.rdf,v
done
Checking in toolkit/mozapps/extensions/test/unit/addons/test_bug425657/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug425657/install.rdf,v  <--  install.rdf
initial revision: 1.1
done

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050706 Minefield/3.0pre.