425825 - offline dialog checkboxes can't be (un)ticked

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Tuukka Tolvanen (sp3000)]

Account settings -> an imap or nntp account -> offline & disk space -> select newsgroups for offline use: click at checkboxes next to folders:
result: no effect
expected: checkbox state changes

tbird trunk linux 20080323

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

It would be interesting to try and narrow down the regression range here.  This problem has been around for at least a month or so, possibly considerably longer.

Comment 2

[Phil Ringnalda (:philor)]

Sigh. Regression window would be 2008-03-02 16:03, because http://mxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/msgSynchronize.js#127 depends on the definition of msgWindowContractID that used to be in mail/base/content/mailWindow.js, and mailnews/base/resources/content/msgSelectOffline.xul thinks that by including mailWindow.js, it can save 15 characters of typing in  msgSynchronize.js (at the expense of rather extreme action at a distance).

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Comment 5

[[e-mail]]

(In reply to comment #2)
> mailnews/base/resources/content/msgSelectOffline.xul thinks that by including
> mailWindow.js, it can save 15 characters of typing in msgSynchronize.js (at
> the expense of rather extreme action at a distance).
Was this the only reason it included mailWindow.js?

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

Indeed, near as I can tell that's the only thing it was providing. Of course, I'm the same one who reviewed causing the regression in the first place, so it's hard to say just how well I can tell...

Comment 7

[Phil Ringnalda (:philor)]

mailnews/base/resources/content/msgSelectOffline.xul 1.29
mailnews/base/resources/content/msgSynchronize.js 1.22

Comment 8

[Tuukka Tolvanen (sp3000)]

v 2008051911 that checkbozes get and lose ticks on click as expected