Closed Bug 425825 Opened 14 years ago Closed 14 years ago

offline dialog checkboxes can't be (un)ticked

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: tuukka.tolvanen, Assigned: philor)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Account settings -> an imap or nntp account -> offline & disk space -> select newsgroups for offline use: click at checkboxes next to folders:
result: no effect
expected: checkbox state changes

tbird trunk linux 20080323
Flags: blocking-thunderbird3.0a1?
It would be interesting to try and narrow down the regression range here.  This problem has been around for at least a month or so, possibly considerably longer.
Keywords: regression
Whiteboard: qawanted
OS: Linux → All
Hardware: PC → All
Sigh. Regression window would be 2008-03-02 16:03, because http://mxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/msgSynchronize.js#127 depends on the definition of msgWindowContractID that used to be in mail/base/content/mailWindow.js, and mailnews/base/resources/content/msgSelectOffline.xul thinks that by including mailWindow.js, it can save 15 characters of typing in  msgSynchronize.js (at the expense of rather extreme action at a distance).
Blocks: 416666
Whiteboard: qawanted
Attached patch Fix v.1 (obsolete) — Splinter Review
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #312423 - Flags: superreview?(neil)
Attachment #312423 - Flags: review?(neil)
Duplicate of this bug: 426072
(In reply to comment #2)
> mailnews/base/resources/content/msgSelectOffline.xul thinks that by including
> mailWindow.js, it can save 15 characters of typing in msgSynchronize.js (at
> the expense of rather extreme action at a distance).
Was this the only reason it included mailWindow.js?
Attached patch Fix v.2Splinter Review
Indeed, near as I can tell that's the only thing it was providing. Of course, I'm the same one who reviewed causing the regression in the first place, so it's hard to say just how well I can tell...
Attachment #312423 - Attachment is obsolete: true
Attachment #312838 - Flags: superreview?(neil)
Attachment #312838 - Flags: review?(neil)
Attachment #312423 - Flags: superreview?(neil)
Attachment #312423 - Flags: review?(neil)
Attachment #312838 - Flags: superreview?(neil)
Attachment #312838 - Flags: superreview+
Attachment #312838 - Flags: review?(neil)
Attachment #312838 - Flags: review+
mailnews/base/resources/content/msgSelectOffline.xul 1.29
mailnews/base/resources/content/msgSynchronize.js 1.22
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
v 2008051911 that checkbozes get and lose ticks on click as expected
Status: RESOLVED → VERIFIED
Flags: blocking-thunderbird3.0a1?
You need to log in before you can comment on or make changes to this bug.