425854 - Search bar inside Library is cut-off for default Library window width

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Not visible Save button for searches with the default window width

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

If you create a fresh profile and start a search within the Library some elements on the right side are cut-off. This also applies to the Save button. Users will not recognize it and will not be able to save the search.

Steps to reproduce:
1. Create a fresh profile and open the Library
2. Search for "Mozilla"

=> Search bar is cut-off after "Bookmarks Toolbar" and Save button is not visible. See also the attached screenshot.

The Library window width should be increased to show all these elements which includes the Save button.

Asking for blocking-firefox3 after talking with Alex on IRC.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, we need to remove a flex from the XUL, and change the default size of that window.

Comment 2

[Asaf Romano (gone)]

I don't know what remove flex means.

Comment 3

[Mike Connor [:mconnor]]

Well, this needs a minor rethink.  The current design already requires a 812 pixel wide window on Mac in en-US.  It'll be worse in German and other locales with longer strings... 

Comment 4

[Mike Connor [:mconnor]]

Ok, discussed with beltzner, we have a plan:

need to implement bug 405887 first, so that search is based on the selected folder.  Then, we want to remove the selector options and have this bar just show the search context and the save button.

So, if History is selected on the left, you'd have:

| Search: History for "foo"                   (Save) |

This is slightly less powerful, but with bug 405887 we're in pretty good shape.

Comment 5

[Marco Bonardo [:mak]]

so this can be done in bug 405887, i had started removing that bar, but then i thought that we were removing a feature that could be useful (if i don't find a result in this folder, i can move looking in full bookmarks or history). so it could be instead simplified to a 

Search: Selected folder | All bookmarks | history

The search will select the correct scope between these, the user will still be able to move to history or full bookmarks search, and removing toolbar and menu items will gain a lot of space (Bookmarks Toolbar and Bookmarks Menu are quite long strings).

Comment 6

[Marco Bonardo [:mak]]

oops, sorry for spam, wrong click :(

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

The patch on bug 405887 does solve the hiding of the save button. But shouldn't we add a small padding to the right side so it isn't directly placed near the window border?

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> The patch on bug 405887 does solve the hiding of the save button. But shouldn't
> we add a small padding to the right side so it isn't directly placed near the
> window border?

on Windows that's ok, can you post a patch for pinstripe? (i don't have a Mac so i can't trimmer a correct padding for that)

Comment 9

[Marco Bonardo [:mak]]

please, annotate the padding request on bug 428031. 
i'm going to mark this fixed since the save button is not cut-away anymore.

fixed by the patch in bug 405887.

Comment 10

[Marco Bonardo [:mak]]

better, fill a new bug for padding, with Mac OS X as the only affected system

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041404 Minefield/3.0pre ID:2008041404

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041406 Minefield/3.0pre

I filed bug 429079 for the remaining issue.

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv