425950 - Thunderbird fails to start after updating to 20080329 nightly build [@ js_SweepScopeProperties][@ JS_CallTracer]

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P1)

Description

[u88484]

After auto-updating to today's (20080329) nightly, upon restart Firefox crashed (http://crash-stats.mozilla.com/report/index/2aeb6e4f-fd86-11dc-af5f-001a4bd43e5c?date=2008-03-29-11 not sure if related), went to start Thunderbird and after asking which profile I wanted to use nothing happens...nothing in the task manager either.

Comment 1

[Phil Ringnalda (:philor)]

No idea why such a thing happens, but I wound up with a compreg.dat with a rather inadequate [Components] section, only including

rel:jar50.dll,1206806835910
rel:xpinstal.dll,1206806836723
rel:jsd3250.dll,1206806836207

After deleting compreg.dat, it regenerates just fine.

Comment 3

[Bob Clary [:bc] (inactive)]

bp-2aeb6e4f-fd86-11dc-af5f-001a4bd43e5c
bp-39ce2363-fdad-11dc-ba94-001a4bd43ef6

I also crashed on restart on linux with 
bp-a7d61c9c-fdba-11dc-b284-001a4bd43e5c 
which is a difference but related js gc stack

brendan,igor: i updated bug 425955 here, but is this really a thunderbird bug or is it really JS Engine?

Comment 4

[Joe Sabash [:JoeS1]]

(In reply to comment #1)
> No idea why such a thing happens, but I wound up with a compreg.dat with a
> rather inadequate [Components] section, only including
> 
> rel:jar50.dll,1206806835910
> rel:xpinstal.dll,1206806836723
> rel:jsd3250.dll,1206806836207
> 
> After deleting compreg.dat, it regenerates just fine.
> 
The build works for me, but if your regenerated compreg.dat does not include:
@mozilla.org/parental-controls-service;1,{580530e5-118c-4bc7-ab88-bc2cd2b97223}
I think it might bite again on the next update.
See Bug 412374
Just my WAG

Comment 5

[Marco Zehe (:MarcoZ)]

(In reply to comment #4)
> The build works for me, but if your regenerated compreg.dat does not include:
> @mozilla.org/parental-controls-service;1,{580530e5-118c-4bc7-ab88-bc2cd2b97223}
> I think it might bite again on the next update.
> See Bug 412374

That bug implies that it might be a Vista-specific problem. However I'm seeing the failure on WinXP SP2, and Bob is also reporting a problem on Linux, so this may not be it...

Comment 6

[Bob Clary [:bc] (inactive)]

Note that I did a clobber build for thunderbird (but it was a 64 bit build) and can start up fine. I also removed the old nightly thunderbird directory and untarred a fresh copy of today's thunderbird build and it starts fine. Is an XDR version change necessary due to Igor's backout of bug 424376 ?

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

My tests:

Thunderbird version 3.0a1pre (2008032914) on XP SP2 (just before 4pm PDT) hourly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032902) on XP SP2 nightly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032802) on XP SP2 nightly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032802) to 2008032902 nightly update crashes.

Thunderbird version 3.0a1pre (2008032915) on Mac OS X 10.5.2 (just before 4pm PDT) hourly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032903) on Mac OS X 10.5.2 nightly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032803) on Mac OS X 10.5.2 nightly starts up fine on a fresh profile.
Thunderbird version 3.0a1pre (2008032803) to 2008032903 nightly update crashes.


Topcrasher on all 3 platforms these few days:

js_SweepScopeProperties - 

http://crash-stats.mozilla.com/report/list?range_unit=days&query_search=signature&query_type=contains&product=Thunderbird&version=Thunderbird%3A3.0a1pre&branch=1.9&signature=js_SweepScopeProperties&range_value=3

JS_CallTracer - 

http://crash-stats.mozilla.com/report/list?range_unit=days&query_search=signature&query_type=contains&product=Thunderbird&version=Thunderbird%3A3.0a1pre&branch=1.9&signature=JS_CallTracer&range_value=3

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I've nailed it down to bug 424964:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-28+00%3A00%3A00&maxdate=2008-03-29+23%3A59%3A59&cvsroot=%2Fcvsroot

which had contained jsscope.c (for js_SweepScopeProperties) and jsgc.c (JS_CallTracer).

Probably a js change that busted Thunderbird's app update.

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Or bug 423874 or bug 424376 (related js checkins that only involved jsgc.c but not jsscope.c)

Comment 10

[Joe Sabash [:JoeS1]]

Could be that the only failing builds are those that come from partial updates.
I haven't seen anyone who used a full download experience the problem.

Or, the worst case scenario. We could be looking at two bugs.
one for the crash, and one for the failure to start.

 

Comment 11

[timeless]

Signature	js_SweepScopeProperties
UUID	2aeb6e4f-fd86-11dc-af5f-001a4bd43e5c
Time	2008-03-29 04:47:15-07:00
Uptime	10
Product	Thunderbird
Version	3.0a1pre
Build ID	2008032902
OS	Windows NT
OS Version	5.1.2600 Service Pack 2
CPU	x86
CPU Info	AuthenticAMD family 15 model 47 stepping 2
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x0
Comments	
Crashing Thread
Frame 	Signature 	Source
0 	js_SweepScopeProperties 	mozilla/js/src/jsscope.c:1832
1 	js_GC 	mozilla/js/src/jsgc.c:3433
2 	js_DestroyContext 	mozilla/js/src/jscntxt.c:433
3 	JS_DestroyContext 	mozilla/js/src/jsapi.c:1025
4 	XPCJSContextStack::SetSafeJSContext(JSContext*) 	mozilla/js/src/xpconnect/src/xpcthreadcontext.cpp:275
5 	nsXPCThreadJSContextStackImpl::SetSafeJSContext(JSContext*) 	mozilla/js/src/xpconnect/src/xpcthreadcontext.cpp:431
6 	nsAppShellService::SetXPConnectSafeContext() 	mozilla/xpfe/appshell/src/nsAppShellService.cpp:123
7 	nsAppShellService::CreateHiddenWindow(nsIAppShell*) 	mozilla/xpfe/appshell/src/nsAppShellService.cpp:197
8 	nsAppStartup::CreateHiddenWindow() 	mozilla/toolkit/components/startup/src/nsAppStartup.cpp:149
9 	XRE_main 	mozilla/toolkit/xre/nsAppRunner.cpp:3044
10 	NS_internal_main(int, char**) 	mozilla/mail/app/nsMailApp.cpp:91
11 	wmain 	mozilla/toolkit/xre/nsWindowsWMain.cpp:87
12 	__tmainCRTStartup 	crtexe.c:594
13 	BaseProcessStart 	

Signature	JS_CallTracer
UUID	a7d61c9c-fdba-11dc-b284-001a4bd43e5c
Time	2008-03-29 11:04:33-07:00
Uptime	3
Product	Thunderbird
Version	3.0a1pre
Build ID	2008032903
OS	Linux
OS Version	0.0.0 Linux 2.6.18-53.1.14.el5 #1 SMP Wed Mar 5 11:37:38 EST 2008 x86_64 GNU/Linux
CPU	x86
CPU Info	GenuineIntel family 10 model 23 stepping 6
Crash Reason	SIGSEGV
Crash Address	0xf7f8219b
Comments	update, restart
Crashing Thread
Frame 	Signature 	Source
0 	JS_CallTracer 	mozilla/js/src/jsgc.c:2483
1 	fun_trace 	mozilla/js/src/jsfun.c:1403
2 	js_TraceObject 	mozilla/js/src/jsobj.c:5019
3 	JS_TraceChildren 	mozilla/js/src/jsgc.c:2233
4 	JS_CallTracer 	mozilla/js/src/jsgc.c:2521
5 	js_TraceObject 	mozilla/js/src/jsobj.c:5041
6 	JS_TraceChildren 	mozilla/js/src/jsgc.c:2233
7 	JS_CallTracer 	mozilla/js/src/jsgc.c:2521
8 	js_TraceObject 	mozilla/js/src/jsobj.c:5041
9 	JS_TraceChildren 	mozilla/js/src/jsgc.c:2233
10 	JS_CallTracer 	mozilla/js/src/jsgc.c:2521
11 	js_CallValueTracerIfGCThing 	mozilla/js/src/jsgc.c:2569
12 	gc_root_traversal 	mozilla/js/src/jsgc.c:2625
13 	JS_DHashTableEnumerate 	mozilla/js/src/jsdhash.c:716
14 	js_TraceRuntime 	mozilla/js/src/jsgc.c:2879
15 	js_GC 	mozilla/js/src/jsgc.c:3240
16 	js_DestroyContext 	mozilla/js/src/jscntxt.c:433
17 	JS_DestroyContext 	mozilla/js/src/jsapi.c:1025
18 	XPCJSContextStack::SetSafeJSContext(JSContext*) 	mozilla/js/src/xpconnect/src/xpcthreadcontext.cpp:275
19 	nsAppShellService::SetXPConnectSafeContext() 	mozilla/xpfe/appshell/src/nsAppShellService.cpp:123
20 	nsAppShellService::CreateHiddenWindow(nsIAppShell*) 	mozilla/xpfe/appshell/src/nsAppShellService.cpp:197
21 	nsAppStartup::CreateHiddenWindow() 	mozilla/toolkit/components/startup/src/nsAppStartup.cpp:149
22 	XRE_main 	mozilla/toolkit/xre/nsAppRunner.cpp:3044
23 	main 	mozilla/mail/app/nsMailApp.cpp:91
24 	libc-2.5.so@0x15deb 	

Comment 12

[Magnus Melin [:mkmelin]]

Crashing with the full install too, on linux. E.g. a7f0825e-fe5c-11dc-82f4-001a4bd43e5c or a5902b23-fe5c-11dc-bfff-001a4bd43e5c though I'm not completely sure it's the same cause.

Comment 13

[Magnus Melin [:mkmelin]]

bp-a7f0825e-fe5c-11dc-82f4-001a4bd43e5c or bp-a5902b23-fe5c-11dc-bfff-001a4bd43e5c

Comment 14

[Magnus Melin [:mkmelin]]

My crashes (in case it's affecting others too) turned out to be due to the Nightly Tester Tools extension. Disabled it and can start thunderbird and firefox trunk builds again.

Comment 15

[u88484]

No NTT extension here.

Comment 16

[Marco Zehe (:MarcoZ)]

(In reply to comment #15)
> No NTT extension here.

Me neither. The only extensions I have are Enigmail (Nightly build for Thunderbird/SeaMonkey trunk) and DOM Inspector, as downloaded from amo.

Comment 17

[Joe Sabash [:JoeS1]]

Since I see no further crashing here:
http://crash-stats.mozilla.com/report/list?range_unit=weeks&version=Thunderbird%3A3.0a1pre&range_value=2&signature=js_SweepScopeProperties
http://crash-stats.mozilla.com/report/list?range_unit=weeks&version=Thunderbird%3A3.0a1pre&range_value=2&signature=JS_CallTracer

I also see now new comments on the builds forum, I think we can assume this bug fixed by one or more of the javascript checkins:
2008-03-29 06:38  424964
http://bonsai.mozilla.org/cvsview2.cgi?subdir=mozilla/js/src&files=jsscope.c&command=DIRECTORY&branch=HEAD&root=/cvsroot

Affected parties should just overlay with a full download, and carry on.
If 'build config' had anything to do with this, just file another bug.

BTW I don't hear a lot of complaints that "Johnny is watching porn on usenet again" So that parental-controls BS should just go away.

Comment 18

[Marco Zehe (:MarcoZ)]

I am still crashing with today's build, or with builds made from current CVS source.  This problem is definitely still there.

Comment 19

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Marking blocking for JS folks to investigate..

Comment 20

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Upgrading from the previous day's nightly to version 3.0a1pre (2008040303) on 10.5 fresh profile works as intended. No crash.

Will resolve as WFM if no crash reports come up anymore in the next week or two.

Comment 21

[Marco Zehe (:MarcoZ)]

I also updated successfully on Windows to version 3.0a1pre (2008040302).

Comment 22

[Mike Schroepfer]

(In reply to comment #20)
> Upgrading from the previous day's nightly to version 3.0a1pre (2008040303) on
> 10.5 fresh profile works as intended. No crash.
> 
> Will resolve as WFM if no crash reports come up anymore in the next week or
> two.
> 

Gary - should we close this out now?

Comment 23

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Searching Breakpad reports till today reveal no more crashes after 20080329 build, neither at js_SweepScopeProperties nor at  JS_CallTracer.

-> WFM.