426083 - Changes needed to build standalone XULRunner on BeOS ( branch 1.8 )

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[mmadia]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.14pre) Gecko/20080320 BonEcho/2.0.0.14pre
Build Identifier: 

Currently the standalone component, XULRunner does not build on BeOS.
This bug id provides a patch to resolve that issue.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[mmadia]

Attachment: preliminary patch

does Volume.h need to be included?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 312631 [details] [diff] [review]
preliminary patch

>Index: stub/nsXULStub.cpp
>===================================================================
>+//Added code to include necessary BEOS header for BEOS specific code
>+#ifdef XP_BEOS
>+//#include <StorageKit.h>
>+#include <Entry.h>
>+#include <Path.h>
>+#include <Volume.h>
>+#endif
>+

Why is StorageKit.h commented out?

> 
>-#ifndef XP_WIN
>+#ifdef XP_BEOS
>+  putenv(strcat("XPCOM_SEARCH_KEY=", greDir));
>+#else
>   setenv(XPCOM_SEARCH_KEY, greDir, 1);
> #endif
> 

Isn't the #ifndef XP_WIN needed inside the #else ? Or you could keep it like this:

> #ifndef XP_WIN
>+#ifdef XP_BEOS
>+  putenv(strcat("XPCOM_SEARCH_KEY=", greDir));
>+#else
>   setenv(XPCOM_SEARCH_KEY, greDir, 1);
> #endif
>+#endif

Comment 3

[mmadia]

originally these changes were included in another patch: id=425962
as per requested in https://bugzilla.mozilla.org/show_bug.cgi?id=425962#c8 ,  i made this patch.   
 
<Entry.h>, <Path.h>, <Volume.h>  are individual parts of <StorageKit.h>
I forgot to completely remove the //#include <StorageKit.h> when creating this patch.

Later I'll test your suggestions and post a new patch.

Comment 4

[mmadia]

Attachment: second version

has mfinkle's suggestions,
"-lgame" was removed from xulrunner/app/Makefile.in,
"#include <Volume.h>" was removed from xulrunner/stub/nsXULStub.cpp, xulrunner was built successfully.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 312657 [details] [diff] [review]
second version

Thanks for minimizing the code changes. No other OS should be affected by your changes now either.

Without BeOS, I can't test the changes, but I trust you if you say they work.

Nit:
+  if (err == B_OK)
+    //p.Path returns a pointer, so use strcpy to store path in iniPath
+    strcpy(iniPath, p.Path());
+
+
+#else 

Extra line that should be removed before checkin.

Comment 6

[tqh]

What do you mean "-lgame" was removed?

The game library is used for sound output in widget/src/beos and when statically linking the binary it is needed.

Comment 7

[mmadia]

Attachment: mozconfig used for building -- for reference only

Originally, I added -lgame expecting it to be needed, much like other mozilla applications.
However, XULRunner will not allow itself to be built statically.
More specifically:
configure: error: --enable-libxul is not compatible with --enable-static

So while implementing the requested changes, I tried removing -lgame and it built successfully.

Attached is the mozconfig used, for reference purposes.

Comment 8

[Samuel Sidler (old account; do not CC)]

Comment on attachment 312657 [details] [diff] [review]
second version

Approved for 1.8.1.15. a=ss.

Comment 9

[mmadia]

requesting checkin on trunk and branch 1_8

Comment 10

[mmadia]

Attachment: third version

As per request, the extra line has been removed for checkin.

Comment 11

[Damon Sicore (:damons)]

Comment on attachment 313495 [details] [diff] [review]
third version

BeOS only.  a1.9+=damons

Comment 12

[Reed Loden [:reed]]

Attachment: what I landed

this is what I landed for trunk

Comment 13

[Reed Loden [:reed]]

Checking in xulrunner/app/Makefile.in;
/cvsroot/mozilla/xulrunner/app/Makefile.in,v  <--  Makefile.in
new revision: 1.40; previous revision: 1.39
done
Checking in xulrunner/stub/nsXULStub.cpp;
/cvsroot/mozilla/xulrunner/stub/nsXULStub.cpp,v  <--  nsXULStub.cpp
new revision: 1.14; previous revision: 1.13
done

Comment 14

[Reed Loden [:reed]]

MOZILLA_1_8_BRANCH:

Checking in xulrunner/app/Makefile.in;
/cvsroot/mozilla/xulrunner/app/Makefile.in,v  <--  Makefile.in
new revision: 1.23.2.4; previous revision: 1.23.2.3
done
Checking in xulrunner/stub/nsXULStub.cpp;
/cvsroot/mozilla/xulrunner/stub/nsXULStub.cpp,v  <--  nsXULStub.cpp
new revision: 1.1.2.9; previous revision: 1.1.2.8
done