426140 - Wrong sort order for priority

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Larsen]

User-Agent:       Opera/9.26 (Windows NT 5.1; U; en)
Build Identifier: 0.8 RC1

When I click on the ! within the task list header, I assume that the items will be ordered by priority, i.e. high > normal > low. This is not the case as the order is high > low > normal.


Reproducible: Always

Steps to Reproduce:
1. Click on priority column header
2.
3.

Comment 1

[Stefan Sitter [:ssitter]]

Please clarify: Is the priority for the task set to Normal or to None (default)?

Comment 2

[Larsen]

Ah, okay. This could be the problem. I assumed that tasks with no explicit priority set have prio normal. What´s the difference between no prio and normal?

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix order - v1

From a user-standpoint, I also think that there should be no difference. From a technical standpoint, items with no priority set will not have a PRIORITY field (see rfc2445 chapter 4.8.1.9 Priority), while "normal" priority will be something like PRIORITY:5.

I think we should modify the sort order to make no-priority items be "normal".

Comment 4

[Stefan Sitter [:ssitter]]

See also discussion in Bug 266602 and Bug 357384 that introduced the current sort order. Sorting "None" together with "Normal" was considered but discarded.

Comment 5

[Christian Jansen]

Comment on attachment 312885 [details] [diff] [review]
Fix order - v1

Works for me. THanks for the patch. ui-r=christian

Comment 6

[Berend Cornelius]

Comment on attachment 312885 [details] [diff] [review]
Fix order - v1

patch works as advertised; r=berend

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 8

[Omar Bajraszewski]

Verified with Lt 2006041006 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/20080410 Calendar/0.9pre