426292 - Add support for Hildon (Maemo) filepicker

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Maemo applications, mobile Nokia n810, for example, have a native file picker dialog that is not the sameas the normal GTK file picker. It is designed for smaller screens. Supporting the Hildon file picker is pretty important for any Mozilla mobile work on that platform, from a widget standpoint.

Comment 1

[Joone Hur]

Attachment: Adding a hildon menu with a file picker

Comment 2

[Joone Hur]

Attachment: Adding a feature of opening a local file

Comment 3

[Joone Hur]

These patches implemented a feature of opening a local file using the hildon system menu & file chooser widget.

But, I'm not sure if this is a right approach because the menu was implemented in a native way instead of using XUL. So we seem to need some mobile specific XUL elements.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

This feature has already landed in bug 511290

Comment 5

[moralka69]

Comment on attachment 363558 [details] [diff] [review]
Adding a feature of opening a local file

>diff -r d7c72600678e chrome/content/browser.js
>--- a/chrome/content/browser.js	Fri Feb 20 15:51:34 2009 -0500
>+++ b/chrome/content/browser.js	Sun Feb 22 19:45:54 2009 +0900
>@@ -161,6 +161,8 @@
>     var os = Cc["@mozilla.org/observer-service;1"].getService(Ci.nsIObserverService);
>     os.addObserver(gXPInstallObserver, "xpinstall-install-blocked", false);
>     os.addObserver(gXPInstallObserver, "xpinstall-download-started", false);
>+    os.addObserver(menuObserver, "menu_openFile", false);
>+   
> 
>     // XXX hook up memory-pressure notification to clear out tab browsers
>     //os.addObserver(function(subject, topic, data) self.destroyEarliestBrowser(), "memory-pressure", false);
>@@ -948,6 +950,20 @@
>     gPrefService.setBoolPref("privacy.popups.showBrowserMessage", !showMessage);
>     Browser.getNotificationBox().removeCurrentNotification();
>   }
>+};
>+
>+const menuObserver = {
>+   observe: function(aSubject, aTopic, aData)
>+   {
>+       switch (aTopic) {
>+         case "menu_openFile":
>+           BrowserUI.goToURI("file://" + aData);
>+           break;
>+         default:
>+           //dump("Error:" + aTopic);
>+           break;
>+       }
>+   }
> };
> 
> const gXPInstallObserver = {

Comment 6

[moralka69]

(In reply to Mark Finkle (:mfinkle) (use needinfo?) from comment #0)

Maemo applications, mobile Nokia n810, for example, have a native file
picker dialog that is not the sameas the normal GTK file picker. It is
designed for smaller screens. Supporting the Hildon file picker is pretty
important for any Mozilla mobile work on that platform, from a widget
standpoint.

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Please submit the patch via phabricator:
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Thanks.

Comment 8

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Also please open a new bug for it, this one is finished.