426468 - Sandboxed items cannot be downloaded even when logged in

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Kai Liu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13
Build Identifier: 

Even when I am logged in, I cannot download a sandboxed item.  The downloaded file, although it has a .XPI extension, is actually a HTML error page saying "The add-on you're looking for is in the sandbox, which you do not have enabled in your user preferences."  There does not appear to be any place where I could set this aforementioned user preference.

Reproducible: Always

Steps to Reproduce:
1. Log into AMO.
2. Go to a sandboxed extension.
3. Note that the download button is green indicating that you can download.
4. Download.
Actual Results:  
The browser complains that the download is corrected.  Upon inspection of the downloaded item, it is not a XPI file as it claims to be, but the data is a HTML error message saying "The add-on you're looking for is in the sandbox, which you do not have enabled in your user preferences."

Expected Results:  
A XPI file containing real data that the browser can install.

Comment 1

[Fred Wenzel [:wenzel]]

Ah, thanks for filing this. As a workaround you can enable "show experimental add-ons" on the add-ons listing page (= the "see all ...add-ons" page(s)), then you should be able to install them when logged in.

I will fix this.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Replace sandbox check by logged in check

The problem was, that downloads shouldn't be restricted by user preference (anymore) but by login only.

Wil, do you mind reviewing?

Comment 3

[Kai Liu]

(In reply to comment #1)
> As a workaround you can enable "show experimental
> add-ons" on the add-ons listing page (= the "see all ...add-ons" page(s)), then
> you should be able to install them when logged in.
> 
Ah, OK.  Before filing, I had searched the UI for some sort of user preference or some other toggle like this, but I had only looked on the account page, the extension's info page, the front page, the category page, and the search page, but I didn't poke around the listings pages accessible through the category pages, so I never found this option.  So while not directly related to the bug, perhaps this option should be more easily discoverable?  For example, it's not available for search results, and when I tried to search for a sandboxed extension, the search returned no results.

> I will fix this.
> 
Thanks.

Comment 4

[Justin Scott [:fligtar]]

Comment on attachment 313048 [details] [diff] [review]
Replace sandbox check by logged in check

r=fligtar

Comment 5

[Fred Wenzel [:wenzel]]

Thanks for the review, fligtar.

Committed to r11883.

Comment 7

[mh512]

Temp work around:
Goto https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:1?show=10&exp=on&sort=updated

and make sure "show experimental add-ons" is checked.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; see above screenshot.

Comment 10

[Jamie Thompson]

I still get this. I am completely unable to download the current FF3 googlebar XPI due to this problem. this is on two independent FF3 installs.

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #10)
> I still get this. I am completely unable to download the current FF3 googlebar
> XPI due to this problem. this is on two independent FF3 installs.
> 

Jamie: Do you have third-party cookies disabled? If so, enable them please, and it will work. That problem is bug 437174.