426914 - API should return results from the larger recommended set

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Basil Hashem [:baz]]

It appears that the API is treating the RecoList as a singular entity when in fact, there are:
- Universal (all locales) vs. locale-specific add-ons variants of these two lists;
  - Featured add-ons (which appear on the front page)
  - Recommended add-ons (which appear in particular categories)

I wanted to think thru with you guys and figure out for Firefox whether we should be returning perhaps a merge of the universal and locale-specific sets as well as changing the default behavior from only including the "Featured add-ons" to including the union of the category recommended add-ons.

This has a couple of benefits:
- Larger pool to draw from
- Locale experience is much improved

The current plan (for say, en-US) is to have about 20 featured add-ons that rotate every 2-3 weeks selected from the Recommended Add-on Set (14 categories x 10 add-ons = 140).

Comment 1

[Laura Thomson :laura]

The API should return for *recommended* a subset of the union of the featured and recommended lists.  The *featured* request should still return the featured addons.

Returned list is locale specific already, this could do with testing.  

We should backfill the results with en-US.

Comment 2

[Laura Thomson :laura]

Attachment: Fix!

Comment 3

[Laura Thomson :laura]

Committed in r14508.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Laura / Dave: do we have a testcase for this I can get to today?  Thanks!

Comment 5

[Laura Thomson :laura]

You can pull the recommended list via 
https://services.addons.mozilla.org/en-US/firefox/api/1.1/list/recommended/all/100
You'll see there are 28 or so results, matching the set of featured addons.

If you check 
https://preview.addons.mozilla.org/en-US/firefox/api/1.1/list/recommended/all/100
you get a lot more, including category recommendations such as Splash!

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

laura++ for easy-to-verify testcases.

Verified FIXED, following the steps in comment 5.

Comment 7

[Justin Scott [:fligtar]]

3.4.5 was pushed on Friday.