Closed Bug 427143 Opened 15 years ago Closed 15 years ago

Crash [@ nsNativeDragTarget::ProcessDrag] with print progress dialog while dragging


(Core :: Widget: Win32, defect)

Windows XP
Not set





(Reporter: martijn.martijn, Assigned: smaug)



(Keywords: crash, regression, testcase)

Crash Data


(2 files)

Attached file testcase
See testcase. You need to download the testcase to your computer because of the use of enhanced privileges.

To reproduce:
- Select the text, then drag it.

Actual result:
Crash (note that the first time you might get a security warning, which might you get stuck in bug 100180)

This regressed between 2008-03-19 and 2008-03-20:
I guess a regression from bug 329385.
0  	xul.dll  	nsNativeDragTarget::ProcessDrag  	 mozilla/widget/src/windows/nsNativeDragTarget.cpp:237
1 	xul.dll 	nsNativeDragTarget::DragOver 	mozilla/widget/src/windows/nsNativeDragTarget.cpp:324
2 	ole32.dll 	ole32.dll@0x118f1d 	
3 	ole32.dll 	ole32.dll@0x119107 	
4 	ole32.dll 	ole32.dll@0xefc2e 	
5 	ole32.dll 	ole32.dll@0xf0087 	
6 	xul.dll 	nsDragService::StartInvokingDragSession 	mozilla/widget/src/windows/nsDragService.cpp:314
7 	xul.dll 	nsDragService::InvokeDragSession 	mozilla/widget/src/windows/nsDragService.cpp:263
8 	xul.dll 	nsBaseDragService::InvokeDragSessionWithSelection 	mozilla/widget/src/xpwidgets/nsBaseDragService.cpp:282
9 	xul.dll 	nsContentAreaDragDrop::DragGesture 	mozilla/content/base/src/nsContentAreaDragDrop.cpp:815
10 	xul.dll 	nsEventListenerManager::HandleEvent 	mozilla/content/events/src/nsEventListenerManager.cpp:1181
see also bug 427643 - very similar stack trace with a crash on drag + alert dialog
Blocks: 427643
And that bug makes it clear that this crash can also occur without the use of enhanced privileges, so marking blocking-1.9?
Flags: blocking1.9?
Assignee: nobody → Olli.Pettay
While this is a regression, it's an edge case that doesn't necessarily keep the user from having a decent experience.  This late in the game, only serious regressions are blockers.  This is something we can take in a dot release.

Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-
I have a fix for that null pointer crash, and I'm just trying to 
figure out how to fix part 1 of bug 427643.
On David Baron proposes canceling the dragging operation before showing any modal dialog, sounds like a nice way of solving it.
Attached patch fix the crashSplinter Review
This should fix the crash
Attachment #314449 - Flags: superreview?(jst)
Attachment #314449 - Flags: review?(jst)
Attachment #314449 - Flags: superreview?(jst)
Attachment #314449 - Flags: superreview+
Attachment #314449 - Flags: review?(jst)
Attachment #314449 - Flags: review+
Attachment #314449 - Flags: approval1.9?
Comment on attachment 314449 [details] [diff] [review]
fix the crash

Attachment #314449 - Flags: approval1.9? → approval1.9+
Checked in. Martijn could you verify?
Closed: 15 years ago
Resolution: --- → FIXED
Yes, thanks, verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041107 Minefield/3.0pre

However, the dragging still seems to be going on, but dropping the text doesn't do something useful. Shouldn't the drag operation be cancelled completely? But I guess that's what bug 100180 is about.
Flags: wanted1.9.0.x+
Crash Signature: [@ nsNativeDragTarget::ProcessDrag]
You need to log in before you can comment on or make changes to this bug.