Closed
Bug 427284
Opened 17 years ago
Closed 17 years ago
Not all region codes are uppercase
Categories
(addons.mozilla.org Graveyard :: Dictionaries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: clouserw, Assigned: clouserw)
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
In our code we normalize the locale code to xx-YY, but that isn't always the case (eg. sr-Latn and ca-valencia). When they don't match, it messes up our dictionary list.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #313836 -
Flags: review?(fwenzel)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 313836 [details] [diff] [review]
fix string comparison
It wfm. What you may want to change before checking it in is removing the second "strtolower" on $locale:
+ $locale = strtolower(implode('-', $locale_parts));
+ if (in_array(strtolower($locale), array_map('strtolower', array_keys($native_languages)))) {
Attachment #313836 -
Flags: review?(fwenzel) → review+
|
||
Updated•17 years ago
|
Keywords: push-needed
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•