427477 - Add foreign key constraints for series table and series_data table

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Tony Fu]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.10) Gecko/20070510 Fedora/1.5.0.10-6.fc6 Firefox/1.5.0.10
Build Identifier: 

Add foreign key information for series table and seris_data table in Bugzilla/DB/Schema.pm file.

Reproducible: Always

Comment 1

[Tony Fu]

Attachment: Add foreign key constraints for series table and series_data table

Comment 2

[Max Kanat-Alexander]

Comment on attachment 314024 [details] [diff] [review]
Add foreign key constraints for series table and series_data table

Is NULL actually OK in the creator field? I know nothing about these tables. Do these foreign keys look right to you, Gerv?

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 314024 [details] [diff] [review]
Add foreign key constraints for series table and series_data table

I'm not completely up on the syntax, but these relationships seem right to me.

Gerv

Comment 4

[Max Kanat-Alexander]

That's good enough for me. As long as creator can be NULL, those all look find to me too.

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.102; previous revision: 1.101
done

Comment 6

[Frédéric Buclin]

Comment on attachment 314024 [details] [diff] [review]
Add foreign key constraints for series table and series_data table

>+            creator     => {TYPE => 'INT3',
>+                            REFERENCES => {TABLE  => 'profiles',
>+                                           COLUMN => 'userid',
>+                                           DELETE => 'SET NULL'}},

gerv, when deleting a user account, editusers.cgi explicitly deletes all series created by this user. So for consistency, it should be DELETE => 'CASCADE' here, not 'SET NULL'. I will file a separate bug for this.