Open
Bug 427619
Opened 17 years ago
Updated 7 years ago
Need style rules for disabled colorpickers
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
NEW
People
(Reporter: iannbugzilla, Unassigned)
References
Details
Attachments
(2 files, 1 obsolete file)
593 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
38.78 KB,
patch
|
neil
:
review-
|
Details | Diff | Splinter Review |
Once the patch on bug 425564 lands we will need rules adding to CSS for when colorpickers are disabled so you can tell visually they are disabled.
I suggest something like
.colorpicker-button-colorbox[disabled="true"] {
border-color: GrayText;
background-color: transparent ! important;
}
This is a patch proposal for this bug, solving both the normal and the type="button" cases. The styles I picked up make sense to me
at least on WinXP but I don't know if they're correct on Mac. I tested the disabled behavior with a xulrunner app of mine, works correctly.
Comments highly welcome.
Comment 4•17 years ago
|
||
Well, it kinda works on Mac - if it's really intended to make the normal colorpicker invisible. I don't think this complete transparency is useful.
Actually, I think that just adding a mere rule
colorpicker[disabled="true"]
{
opacity: 0.5;
}
to the the base themes would be a better solution.
Some nits on the patch itself:
- If you patch winstripe and pinstripe, you should patch gnomestripe as well.
- Is anybody still using /themes at all?
- Is anybody still using /xpfe colorpicker at all?
Comment 5•17 years ago
|
||
(In reply to comment #4)
> Well, it kinda works on Mac - if it's really intended to make the normal
> colorpicker invisible. I don't think this complete transparency is useful.
> Actually, I think that just adding a mere rule
>
> colorpicker[disabled="true"]
> {
> opacity: 0.5;
> }
>
> to the the base themes would be a better solution.
No because it would let appear the underneath background if any... I tried it
and it's rally ugly.
(In reply to comment #4)
> Some nits on the patch itself:
> - If you patch winstripe and pinstripe, you should patch gnomestripe as well.
gnomestripe has no styles at all for colorpicker, it reuses winstripe styles
Attachment #321747 -
Attachment is obsolete: true
Attachment #322622 -
Flags: review?(neil)
Comment 9•17 years ago
|
||
Comment on attachment 322622 [details] [diff] [review]
better patch for mac styles
>+ if (aCell.getAttribute("disabled") != "true") {
>+ aCell.getAttribute("disabled") != "true") {
I don't think you should check for disabled here; script should be able to change the colourpicker's colour whether or not it is disabled. Instead the event handlers should check for this.disabled (an inherited property).
>+.colorpicker-button-colorbox[disabled="true"] {
>+ border-color: GrayText;
Possibly beyond the scope of this bug but the default *stripe border colour is #000000 instead of some OS-specific colour :-(
>+ border: graytext groove thin;
I don't think we normally use groove style, we manually choose two-tone OS colours for the four sides.
>Index: suite/themes/modern/global/colorpicker.css
>+.colorpicker-button-colorbox[disabled="true"] {
>+ border-color: GrayText;
On the other hand, Modern should not use OS colours, it's hardcoded everywhere (typically #8C99AB for disabled text for instance.)
Attachment #322622 -
Flags: review?(neil) → review-
Assignee | ||
Updated•17 years ago
|
Product: Core → SeaMonkey
Comment 10•15 years ago
|
||
To pick this issue up again I am agreeing to Karsten saying, that setting the disabled colorpicker's opacity down is a better solution than trying to create a groove effect for the border and making the inner part transparent. I already implemented this into my add-on Regular Expressions Tester (https://addons.mozilla.org/de/firefox/addon/2077; see display settings) and it looks very well for me. I tried several other styles, but the one mentioned above seems the best for me.
The reason why it shouldn't be totally transparent when disabled is, that then the user can't see the picked color anymore. Though in some cases it would be useful for the user to see the picked color in disabled mode and it would be more compliant to other elements like checkboxes, radio buttons, text fields etc., which show their value even when they are disabled.
You need to log in
before you can comment on or make changes to this bug.
Description
•