427797 - "Dvorak - Qwerty ⌘" keyboard layout is broken

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: Illustration of keyboard layout

(Intro copied from bug 411647)

Mac OS X has a keyboard layout called "Dvorak - Qwerty ⌘" where the keys are
ordinarily in the Dvorak layout, but when the ⌘ (Command) key is held down,
it temporarily switches back to Qwerty. Thus, you can type text in Dvorak, but
all the keyboard shorcuts in your muscle memory still work.

Since bug 398514, this function does not work any more - when the Cmd key is pressed, the Dvorak layout is applied for the keyboard commands.

Steps to reproduce:

1. Set OS X to use the "Dvorak - Qwerty ⌘" keyboard layout (in the
   International preference pane in System Preferences).
2. Open a Firefox window.
3. Press Cmd + [F].

Actual results:
The View Source window opens, which should only open on Cmd+U. At the same time, the "Edit" menu entry flashes blue. (That's where the Find command is located.)

Expected results:
The find bar should appear.

Comment 1

[Joseph Grabko]

Tested and confirmed the presence of this bug with OS X. I use Dvorak often, so this is a severe issue. 

Comment 2

[Stuart Morgan]

Dvorak - Qwerty Command is a nightmare; |charactersIgnoringModifiers| doesn't actually do what you want, but if you use |characters| you get weird effects from shift and option.

Comment 3

[Stuart Morgan]

I mentioned this in channel, but since it might be useful to preserve: this post gives a feeling for the complexity involved here, and has some sample code that handles a subset of the problem:
http://sigpipe.macromates.com/2005/09/24/deciphering-an-nsevent/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

this bug should be fixed by bug 359638. (I'll post new patch for Dvorak)

Comment 5

[Markus Stange [:mstange]]

Yes! That works perfectly. Thanks.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Bug 427995 is probably also related.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

taking.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The patch of bug 359638 was landed.

-> FIXED

Comment 10

[Markus Stange [:mstange]]

Verified Fixed.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041504 Minefield/3.0pre

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5268 added to Litmus.