Closed Bug 427948 Opened 18 years ago Closed 8 years ago

nsNSSSocketInfo is not thread safe

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 698243

People

(Reporter: KaiE, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [psm-backlog])

Class nsNSSSocketInfo is declared as threadsafe, but it's not! It doesn't use any synchronization. According to cvs history, the macro NS_IMPL_THREADSAFE has been used since revision 1 of file nsNSSIOLayer.cpp - it had state variables since day 1 - but it never used any locks. That's bad. The situation has become more dangerous since we're using a separate thread for SSL activity. But I guess that class had been accessed from multiple threads since day one, the original programmer must have had a reason to pick the threadsafe declaration...
I had warned about this 6.5 years ago. Wow. I think it's now time to work on it :-/
Depends on: 101005
-> me
Assignee: kaie → honzab.moz
Releasing for now, but still on my radar. Any one feel free to take this.
Assignee: honzab.moz → nobody
Blocks: 902158
Blocks: 955947
Whiteboard: [psm-backlog]
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Blocks: 101005
No longer depends on: 101005
You need to log in before you can comment on or make changes to this bug.