Open Bug 427972 Opened 17 years ago Updated 9 months ago

Port |Bug 350543 – Add a menu item for Copy/Move to Folder Again| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.1 wontfix)

Status:
ASSIGNED
Tracking Flags:
Tracking Status
seamonkey2.1 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files, 5 obsolete files)

(Av1b-SM) <mail3PaneWindowCommands.js> cleanup/synchronization
49.23 KB, patch
sgautherie
: superreview?
neil
Details | Diff | Splinter Review
(Bv1-TB-Bw) <mail3PaneWindowCommands.js> cleanup/synchronization
22.69 KB, patch
Details | Diff | Splinter Review
(Bv1-TB) <mail3PaneWindowCommands.js> cleanup/synchronization
35.50 KB, patch
philor
: review-
Details | Diff | Splinter Review
Assignee: mail → sgautherie.bz
Status: NEW → ASSIGNED
First, <mail3PaneWindowCommands.js> needs some cleanup / (TB) synchronization: *Removes all tabs; correctly align code; ... *Moves a few lines around, to be more consistent. *2 rewrites. *Removes a "redundant" |break|. NB: Use the Av1-SM-Bw patch to ease review.
Attachment #314612 - Flags: review?
Attachment #314612 - Flags: review? → review?(iann_bugzilla)
Av1-SM-Bw ++.
Attachment #314611 - Attachment is obsolete: true
Av1-SM ++.
Attachment #314612 - Attachment is obsolete: true
Attachment #314647 - Flags: review?(iann_bugzilla)
Attachment #314612 - Flags: review?(iann_bugzilla)
Comment on attachment 314647 [details] [diff] [review] (Av1a-SM) <mail3PaneWindowCommands.js> cleanup/synchronization Looks fine to me on code inspection. What testing have you done?
Attachment #314647 - Flags: review?(iann_bugzilla) → review+
(In reply to comment #5) > (From update of attachment 314647 [details] [diff] [review]) > Looks fine to me on code inspection. What testing have you done? Loading MailNews with the new file, nothing more :-|
Keywords: checkin-needed
Whiteboard: [c-n: Av1a-SM // Leave opened]
(In reply to comment #6) Ian and I talk a little on IRC and agreed that the risk was low enough.
Av1a-SM, with one of the line split. Keeping r+.
Attachment #314646 - Attachment is obsolete: true
Attachment #314647 - Attachment is obsolete: true
Whiteboard: [c-n: Av1a-SM // Leave opened] → [c-n: Av1b-SM // Leave opened]
Av1b-SM port to TB. NB: Use the Bv1-TB-Bw patch to ease review.
Attachment #315450 - Flags: review?(philringnalda)
Ian, aside from this bug, do we want to port bug 421781 from TB ?
sr missing.
Keywords: checkin-needed
Whiteboard: [c-n: Av1b-SM // Leave opened]
Attachment #315447 - Flags: superreview?(neil)
Neil, ping ? Phil, ping ?
Comment on attachment 315450 [details] [diff] [review] (Bv1-TB) <mail3PaneWindowCommands.js> cleanup/synchronization Thanks for thinking of us, but you can go ahead and port our feature without changing our whitespace first.
Attachment #315450 - Flags: review?(philringnalda) → review-
Flags: wanted-seamonkey2?
QA Contact: message-display
This bug is open but targeted for seamonkey2.0a1, which has been released a long time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.
No enhancements any more after SeaMonkey 2.0 feature freeze, so wanted- for this one, can consider it for the next release.
Flags: wanted-seamonkey2.0? → wanted-seamonkey2.0-
Target Milestone: seamonkey2.0a1 → ---
Flags: wanted-seamonkey2.1?
status-seamonkey2.1: --- → wanted
Flags: wanted-seamonkey2.1?
Attachment #9384830 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: