428022 - Category color indicators should be printed

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Steve Lorimer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13
Build Identifier: 2008033120 - Lightning plugin for Thunderbird

When I set a color for a category for an event, Sunbird displays the event with a block to the right of the event containing the category color (new in 0.8.  0.7 placed a border around the event.)  However, this color does not print.  It doesn't appear in the print preview either.

Reproducible: Always

Steps to Reproduce:
1.  Add a category / set a color for the category
2.  Try to print - category color won't print
3.
Actual Results:  
Pretty straightforward

Comment 1

[Martin Schröder [:mschroeder]]

Morphing bug to feature request.

Comment 3

[PM]

Attachment: Patch for colors printing.

The current code contains color printing for categories, but does not work because of a ';' missing from the declaration of style.
In this patch, 'border' is changed to 'border-right' for a report similar to the views.

See example 'sample1.png'

Comment 4

[PM]

Attachment: sample

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 581275 [details] [diff] [review]
Patch for colors printing.

>                 style += ' color: ' + cal.getContrastingTextColor(calColor);
>                 if (catColor) {
>-                    style += ' border: solid ' + catColor + ' 2px;';
>+                    style += '; border-right: solid ' + catColor + ' 7px;';
>                 }
I'd rather have each style += line add its own semicolon, I'll change this before checkin.

r=philipp

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset cfabf39d7be5

Comment 7

[PM]

Attachment: patch formatStringForCSSRule

The category name must be converted using 'formatStringForCSSRule' to read the color in the preferences. 
ex :
Congés => calendar.category.color.cong-uxe9-s

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 584549 [details] [diff] [review]
patch formatStringForCSSRule

r=mschroeder.

Philipp, can you approve this fix for comm-aurora?

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 584549 [details] [diff] [review]
patch formatStringForCSSRule

approval for aurora also

Comment 10

[Martin Schröder [:mschroeder]]

(In reply to Philipp Kewisch [:Fallen] from comment #9)
> Comment on attachment 584549 [details] [diff] [review]
> patch formatStringForCSSRule
> 
> approval for aurora also

https://hg.mozilla.org/comm-central/rev/89c824683851
https://hg.mozilla.org/releases/comm-aurora/rev/7595b1a85c47

Comment 11

[PM]

(In reply to Philipp Kewisch [:Fallen] from comment #9)
> Comment on attachment 584549 [details] [diff] [review]
> patch formatStringForCSSRule
> 
> approval for aurora also

i replaced cat.toLowerCase() by formatStringForCSSRule(cat) in lightning 1.2b2 (+tb10) and categories colors are not printed.
(it works with 1.0b3 version i use)
when adding trace logs, formatStringForCSSRule is not defined.
(formatStringForCSSRule is defined in calendar/content/calendar/calUtils.js file)

Comment 12

[PM]

Attachment: patch-formatStringForCSSRule-v2

this patch change:
formatStringForCSSRule(cat)
to:
cal.formatStringForCSSRule(cat)

this patch solve the problem described in comment 11

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 589807 [details] [diff] [review]
patch-formatStringForCSSRule-v2

Maybe wrong patch (changes toLowerCase to cal.formatString...), but I see what you mean. I'll change it and push in a sec.

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset 2970fc9537af

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-aurora changeset e2828114a2d9