428032 - Separator line 2px instead of 1px in places organizer

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

One of the separator line in places organizer is 2px now instead of one (recent regression. See screenshot.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

Comment 2

[Reed Loden [:reed]]

Anybody want to attach a simple patch to fix this?

Comment 3

[Julien "_FrnchFrgg_" RIVAUD]

I don't think there's a 2px line; it's probably a 1px line which shouldn't be here, and since it's right against the bottom border of the list, you see 2px. I didn't see the bug, I'll recompile latest trunk to see if I see it.

Comment 4

[Julien "_FrnchFrgg_" RIVAUD]

This is a regression from bug 403140

@@ -487,12 +487,9 @@
               </treecols>
               <treechildren flex="1"/>
             </tree>
-            <splitter id="contentSplitter" collapse="after" persist="state">
-              <grippy/>
-            </splitter>
-            <hbox persist="height" id="infoPane">
+            <hbox id="infoPane">
               <deck flex="1" id="detailsDeck">
-                <vbox align="center">
+                <vbox id="itemsCountBox" align="center">
                   <spacer flex="3"/>
                   <label id="itemsCountText"/>
                   <spacer flex="1"/>

This removes the splitter instead of replacing it with a non collapsable splitter. Then the infoPane top border touches the treeview bottom border.
Note that this isn't just cosmetic, the infoPane no longer can be resized, and automatically adapts its height to its content. Since it has been decided in bug 403140 that it would be the way to go, I'd just remove the threedshadow top border of the infoPane...

What do you think ?

Comment 5

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Remove the infoPane top border, it is unneeded and ugly since bug 403140 checkin

Comment 6

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Remove the infoPane top border, it is unneeded and ugly since bug 403140 checkin, v2

Unbitrotted (it had been bitrotted by bug 428020)

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315547 [details] [diff] [review]
Remove the infoPane top border, it is unneeded and ugly since bug 403140 checkin, v2

a1.9=beltzner

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/gnomestripe/browser/places/organizer.css 	1.16