428091 - [Trunk] Unifinder close button icon is misaligned/misplaced

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: screenshot of issue

Sunbirds winstripe theme uses mozilla/toolkit/themes/winstripe/global/icons/close.png to draw the close button icon on the unifinder.

Bug 424028 changed that image for the Firefox 3 theme update. Now each image is sized 14x14 instead of 16x16. This means the rules in calendar-unifinder.css specify a wrong image section: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/calendar/base/themes/winstripe/calendar-unifinder.css&rev=1.5&mark=98,106,110#95

For Trunk we need a change similar to http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=findBar.css&branch=&root=/cvsroot&subdir=/mozilla/toolkit/themes/winstripe/global&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8 to make the icon look OK again.

Comment 1

[Martin Schröder [:mschroeder]]

The closer on the Today pane doesn't show this behavior because it uses the messenger specific closer icon. You can simply compare the corresponding CSS rule:
(1) http://mxr.mozilla.org/seamonkey/source/calendar/base/themes/winstripe/calendar-unifinder.css#85
(2) http://mxr.mozilla.org/seamonkey/source/calendar/base/themes/winstripe/today-pane.css#143

Why do we use a messenger specific icon for the Today pane closer? Also the CSS rule should be similar imo.

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

IMO no ui-review is needed for this change.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 341819 [details] [diff] [review]
Patch v1

Looks good, r=philipp

Comment 4

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0985e8d96c59>

-> FIXED

Comment 5

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081010 Calendar/1.0pre (BuildID: 20081010073800).

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".