Closed
Bug 428091
Opened 16 years ago
Closed 16 years ago
[Trunk] Unifinder close button icon is misaligned/misplaced
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: ssitter, Assigned: mschroeder)
Details
Attachments
(2 files)
1.99 KB,
image/png
|
Details | |
1.97 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Sunbirds winstripe theme uses mozilla/toolkit/themes/winstripe/global/icons/close.png to draw the close button icon on the unifinder. Bug 424028 changed that image for the Firefox 3 theme update. Now each image is sized 14x14 instead of 16x16. This means the rules in calendar-unifinder.css specify a wrong image section: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/calendar/base/themes/winstripe/calendar-unifinder.css&rev=1.5&mark=98,106,110#95 For Trunk we need a change similar to http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=findBar.css&branch=&root=/cvsroot&subdir=/mozilla/toolkit/themes/winstripe/global&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8 to make the icon look OK again.
Assignee | ||
Comment 1•16 years ago
|
||
The closer on the Today pane doesn't show this behavior because it uses the messenger specific closer icon. You can simply compare the corresponding CSS rule: (1) http://mxr.mozilla.org/seamonkey/source/calendar/base/themes/winstripe/calendar-unifinder.css#85 (2) http://mxr.mozilla.org/seamonkey/source/calendar/base/themes/winstripe/today-pane.css#143 Why do we use a messenger specific icon for the Today pane closer? Also the CSS rule should be similar imo.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Target Milestone: --- → 1.0
Assignee | ||
Comment 2•16 years ago
|
||
IMO no ui-review is needed for this change.
Attachment #341819 -
Flags: review?(Berend.Cornelius)
Comment 3•16 years ago
|
||
Comment on attachment 341819 [details] [diff] [review] Patch v1 Looks good, r=philipp
Attachment #341819 -
Flags: review?(Berend.Cornelius) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0985e8d96c59> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•16 years ago
|
||
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081010 Calendar/1.0pre (BuildID: 20081010073800).
Status: RESOLVED → VERIFIED
Comment 6•13 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•