Closed Bug 424028 Opened 17 years ago Closed 17 years ago

beta 5 theme update for windows (xp and vista)

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
x86
Windows Vista
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta5

People

(Reporter: beltzner, Assigned: faaborg)

References

Details

Attachments

(6 files)

Problems with the new icons in the addons manager
37.87 KB, image/png
Details
Fix tab close icon and get add-ons search bar - v1
3.78 KB, patch
Gavin
: review+
beltzner
: approval1.9b5+
Details | Diff | Splinter Review
Fix more tab close icons - v1
6.65 KB, patch
Gavin
: review+
beltzner
: approval1.9b5+
Details | Diff | Splinter Review
new vista icons in addons manager
63.51 KB, image/png
Details
close.png - the first state is wrong, I think
1.90 KB, image/png
Details
New close.png
1.86 KB, image/png
Details
We'll be updating icons in winstripe for both Vista and XP. This will require: - updates to existing icon files to be checked in - new icon files to be checked in - new chrome overrides added to the manifest file for Vista-specific icons Alex will provide a list of the Vista-specific icon files (which will take the pattern of filename-aero.png) so we can start on the manifest patch (see attachment 306823 [details] [diff] [review] for an example of what I mean here).
Flags: blocking-firefox3+
Priority: -- → P1
Honestly, I can do manifest changes when landing without any problems... if we need to do any CSS changes, that might require some more work, but don't worry about trying to get the manifest changes done ahead of time. :)
CSS changes required are in already b5-blocking bug 423806 and bug 423977.
Assignee: nobody → faaborg
Here are all of the new icons: http://people.mozilla.com/~faaborg/temp/beta5/mozilla.zip be sure to check in bugs 423806 and 423977 at the same time, which effects these files: /mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png /mozilla/browser/themes/winstripe/browser/Toolbar-small.png /mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png /mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png
beltzner, approval?
beltzner and I both reviewed the icons together. I am sure he approves but I'm not sure if he will be online later tonight. Please go ahead and land the icons.
(In reply to comment #5) > beltzner and I both reviewed the icons together. I am sure he approves but I'm > not sure if he will be online later tonight. Please go ahead and land the > icons. I meant approval, not ui-review. ;) <mconnor> a=me
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/Bookmarks-folder-aero.png,v done Checking in browser/themes/winstripe/browser/Bookmarks-folder-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Bookmarks-folder-aero.png,v <-- Bookmarks-folder-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/Bookmarks-folder.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Bookmarks-folder.png,v <-- Bookmarks-folder.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/Go-arrow-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow-aero.png,v <-- Go-arrow-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Go-arrow-rtl-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow-rtl-aero.png,v <-- Go-arrow-rtl-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Go-arrow-rtl.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow-rtl.png,v <-- Go-arrow-rtl.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/Go-arrow.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Go-arrow.png,v <-- Go-arrow.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/Info-aero.png,v done Checking in browser/themes/winstripe/browser/Info-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Info-aero.png,v <-- Info-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/Info.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Info.png,v <-- Info.png new revision: 1.4; previous revision: 1.3 done Removing browser/themes/winstripe/browser/Search-bar.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-bar.png,v <-- Search-bar.png new revision: delete; previous revision: 1.3 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass-aero.png,v done Checking in browser/themes/winstripe/browser/Search-glass-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass-aero.png,v <-- Search-glass-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass-rtl-aero.png,v done Checking in browser/themes/winstripe/browser/Search-glass-rtl-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass-rtl-aero.png,v <-- Search-glass-rtl-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/Search-glass-rtl.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass-rtl.png,v <-- Search-glass-rtl.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/Search-glass.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Search-glass.png,v <-- Search-glass.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/Secure-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Secure-aero.png,v <-- Secure-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Secure.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Secure.png,v <-- Secure.png new revision: 1.6; previous revision: 1.5 done Checking in browser/themes/winstripe/browser/Secure24-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Secure24-aero.png,v <-- Secure24-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Secure24.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Secure24.png,v <-- Secure24.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Toolbar-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v <-- Toolbar-aero.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v <-- Toolbar-small-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/Toolbar-small.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v <-- Toolbar-small.png new revision: 1.9; previous revision: 1.8 done Checking in browser/themes/winstripe/browser/Toolbar.png; /cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar.png,v <-- Toolbar.png new revision: 1.10; previous revision: 1.9 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/icon-aero.png,v done Checking in browser/themes/winstripe/browser/icon-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/icon-aero.png,v <-- icon-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/icon.png; /cvsroot/mozilla/browser/themes/winstripe/browser/icon.png,v <-- icon.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/identity-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/identity-aero.png,v <-- identity-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/identity.png; /cvsroot/mozilla/browser/themes/winstripe/browser/identity.png,v <-- identity.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/jar.mn; /cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v <-- jar.mn new revision: 1.80; previous revision: 1.79 done Checking in browser/themes/winstripe/browser/livemark-folder-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/livemark-folder-aero.png,v <-- livemark-folder-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/livemark-folder.png; /cvsroot/mozilla/browser/themes/winstripe/browser/livemark-folder.png,v <-- livemark-folder.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/livemark-item-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/livemark-item-aero.png,v <-- livemark-item-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/livemark-item.png; /cvsroot/mozilla/browser/themes/winstripe/browser/livemark-item.png,v <-- livemark-item.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/menu-back-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/menu-back-aero.png,v <-- menu-back-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/menu-back.png; /cvsroot/mozilla/browser/themes/winstripe/browser/menu-back.png,v <-- menu-back.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/menu-forward-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/menu-forward-aero.png,v <-- menu-forward-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/menu-forward.png; /cvsroot/mozilla/browser/themes/winstripe/browser/menu-forward.png,v <-- menu-forward.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/pageInfo-aero.png,v done Checking in browser/themes/winstripe/browser/pageInfo-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/pageInfo-aero.png,v <-- pageInfo-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/pageInfo.png; /cvsroot/mozilla/browser/themes/winstripe/browser/pageInfo.png,v <-- pageInfo.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preview-aero.png,v done Checking in browser/themes/winstripe/browser/preview-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preview-aero.png,v <-- preview-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/preview.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preview.png,v <-- preview.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon-aero.png,v <-- audioFeedIcon-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon.png,v <-- audioFeedIcon.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon16-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon16-aero.png,v <-- audioFeedIcon16-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/feeds/audioFeedIcon16.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/audioFeedIcon16.png,v <-- audioFeedIcon16.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/feeds/feedIcon-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon-aero.png,v <-- feedIcon-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/feeds/feedIcon.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon.png,v <-- feedIcon.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/feeds/feedIcon16-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon16-aero.png,v <-- feedIcon16-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/feeds/feedIcon16.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/feedIcon16.png,v <-- feedIcon16.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon-aero.png,v <-- videoFeedIcon-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon.png,v <-- videoFeedIcon.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon16-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon16-aero.png,v <-- videoFeedIcon16-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/feeds/videoFeedIcon16.png; /cvsroot/mozilla/browser/themes/winstripe/browser/feeds/videoFeedIcon16.png,v <-- videoFeedIcon16.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksMenu-aero.png,v done Checking in browser/themes/winstripe/browser/places/bookmarksMenu-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksMenu-aero.png,v <-- bookmarksMenu-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/places/bookmarksMenu.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksMenu.png,v <-- bookmarksMenu.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksToolbar-aero.png,v done Checking in browser/themes/winstripe/browser/places/bookmarksToolbar-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksToolbar-aero.png,v <-- bookmarksToolbar-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/places/bookmarksToolbar.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/bookmarksToolbar.png,v <-- bookmarksToolbar.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/collapse-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/collapse-aero.png,v <-- collapse-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/collapse.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/collapse.png,v <-- collapse.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/expand-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/expand-aero.png,v <-- expand-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/expand.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/expand.png,v <-- expand.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/history-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/history-aero.png,v <-- history-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/importAndBackup-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/importAndBackup-aero.png,v <-- importAndBackup-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/importAndBackup.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/importAndBackup.png,v <-- importAndBackup.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/minus-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/minus-aero.png,v <-- minus-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/minus.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/minus.png,v <-- minus.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/organize-aero.png,v done Checking in browser/themes/winstripe/browser/places/organize-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/organize-aero.png,v <-- organize-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/organize.png,v done Checking in browser/themes/winstripe/browser/places/organize.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/organize.png,v <-- organize.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/places/pageStarred-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/pageStarred-aero.png,v <-- pageStarred-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/places/pageStarred.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/pageStarred.png,v <-- pageStarred.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/places/placesIcon.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/placesIcon.png,v <-- placesIcon.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/plus-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/plus-aero.png,v <-- plus-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/plus.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/plus.png,v <-- plus.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/query-aero.png,v done Checking in browser/themes/winstripe/browser/places/query-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/query-aero.png,v <-- query-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/places/query.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/query.png,v <-- query.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/places/starPage-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage-aero.png,v <-- starPage-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/places/starPage.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage.png,v <-- starPage.png new revision: 1.6; previous revision: 1.5 done Checking in browser/themes/winstripe/browser/places/starred48-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/starred48-aero.png,v <-- starred48-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/starred48.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/starred48.png,v <-- starred48.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/places/tag-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/tag-aero.png,v <-- tag-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/places/tag.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/tag.png,v <-- tag.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/view-aero.png,v done Checking in browser/themes/winstripe/browser/places/view-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/view-aero.png,v <-- view-aero.png initial revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/places/view.png,v done Checking in browser/themes/winstripe/browser/places/view.png; /cvsroot/mozilla/browser/themes/winstripe/browser/places/view.png,v <-- view.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/preferences/Options-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options-aero.png,v <-- Options-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/preferences/Options.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options.png,v <-- Options.png new revision: 1.10; previous revision: 1.9 done Checking in browser/themes/winstripe/browser/preferences/alwaysAsk-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/alwaysAsk-aero.png,v <-- alwaysAsk-aero.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/application-aero.png,v done Checking in browser/themes/winstripe/browser/preferences/application-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/application-aero.png,v <-- application-aero.png initial revision: 1.1 done Checking in browser/themes/winstripe/browser/preferences/application.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/application.png,v <-- application.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/preferences/plugin-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin-aero.png,v <-- plugin-aero.png new revision: 1.3; previous revision: 1.2 done Checking in browser/themes/winstripe/browser/preferences/plugin.png; /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v <-- plugin.png new revision: 1.5; previous revision: 1.4 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-end-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end-aero.png,v <-- tab-arrow-end-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-end.png,v <-- tab-arrow-end.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-start-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start-aero.png,v <-- tab-arrow-start-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tab-arrow-start.png,v <-- tab-arrow-start.png new revision: 1.4; previous revision: 1.3 done Checking in browser/themes/winstripe/browser/tabbrowser/tabDragIndicator-aero.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tabDragIndicator-aero.png,v <-- tabDragIndicator-aero.png new revision: 1.2; previous revision: 1.1 done Checking in browser/themes/winstripe/browser/tabbrowser/tabDragIndicator.png; /cvsroot/mozilla/browser/themes/winstripe/browser/tabbrowser/tabDragIndicator.png,v <-- tabDragIndicator.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v <-- jar.mn new revision: 1.47; previous revision: 1.46 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-error-aero.png,v done Checking in toolkit/themes/winstripe/global/console/bullet-error-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-error-aero.png,v <-- bullet-error-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/console/bullet-error.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-error.png,v <-- bullet-error.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-question-aero.png,v done Checking in toolkit/themes/winstripe/global/console/bullet-question-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-question-aero.png,v <-- bullet-question-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/console/bullet-question.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-question.png,v <-- bullet-question.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-warning-aero.png,v done Checking in toolkit/themes/winstripe/global/console/bullet-warning-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-warning-aero.png,v <-- bullet-warning-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/console/bullet-warning.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/bullet-warning.png,v <-- bullet-warning.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/console/console-toolbar-aero.png,v done Checking in toolkit/themes/winstripe/global/console/console-toolbar-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/console-toolbar-aero.png,v <-- console-toolbar-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/console/console-toolbar.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/console/console-toolbar.png,v <-- console-toolbar.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/local-aero.png,v done Checking in toolkit/themes/winstripe/global/dirListing/local-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/local-aero.png,v <-- local-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/dirListing/local.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/local.png,v <-- local.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/remote-aero.png,v done Checking in toolkit/themes/winstripe/global/dirListing/remote-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/remote-aero.png,v <-- remote-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/dirListing/remote.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/remote.png,v <-- remote.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/up-aero.png,v done Checking in toolkit/themes/winstripe/global/dirListing/up-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/up-aero.png,v <-- up-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/dirListing/up.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/dirListing/up.png,v <-- up.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Error-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/Error-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Error-aero.png,v <-- Error-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/Error.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Error.png,v <-- Error.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Landscape-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/Landscape-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Landscape-aero.png,v <-- Landscape-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/Landscape.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Landscape.png,v <-- Landscape.png new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Portrait-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/Portrait-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Portrait-aero.png,v <-- Portrait-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/Portrait.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Portrait.png,v <-- Portrait.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Print-preview-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/Print-preview-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Print-preview-aero.png,v <-- Print-preview-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/Print-preview.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Print-preview.png,v <-- Print-preview.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/global/icons/Question.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Question.png,v <-- Question.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/global/icons/Warning.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/Warning.png,v <-- Warning.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/autoscroll-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/autoscroll-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/autoscroll-aero.png,v <-- autoscroll-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/autoscroll.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/autoscroll.png,v <-- autoscroll.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/close-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close-aero.png,v <-- close-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/close.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/close.png,v <-- close.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/global/icons/find-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find-aero.png,v <-- find-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/find.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/find.png,v <-- find.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/folder-item-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/folder-item-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/folder-item-aero.png,v <-- folder-item-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/folder-item.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/folder-item.png,v <-- folder-item.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/notfound-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/notfound-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/notfound-aero.png,v <-- notfound-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/notfound.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/notfound.png,v <-- notfound.png new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/warning-large-aero.png,v done Checking in toolkit/themes/winstripe/global/icons/warning-large-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/warning-large-aero.png,v <-- warning-large-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/warning-large.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/warning-large.png,v <-- warning-large.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/icons/wrap-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/wrap-aero.png,v <-- wrap-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/global/icons/wrap.png; /cvsroot/mozilla/toolkit/themes/winstripe/global/icons/wrap.png,v <-- wrap.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/mozapps/jar.mn; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v <-- jar.mn new revision: 1.33; previous revision: 1.32 done Checking in toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png,v <-- downloadIcon-aero.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png,v <-- downloadIcon.png new revision: 1.6; previous revision: 1.5 done Checking in toolkit/themes/winstripe/mozapps/extensions/extensionIcons-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionIcons-aero.png,v <-- extensionIcons-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/extensionIcons.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionIcons.png,v <-- extensionIcons.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/notifyBadges-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/extensions/notifyBadges-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/notifyBadges-aero.png,v <-- notifyBadges-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/notifyBadges.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/notifyBadges.png,v <-- notifyBadges.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/question-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/extensions/question-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/question-aero.png,v <-- question-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/question.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/question.png,v <-- question.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings-aero.png,v <-- ratings-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/ratings.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/ratings.png,v <-- ratings.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/searchIcons-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/extensions/searchIcons-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/searchIcons-aero.png,v <-- searchIcons-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/searchIcons.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/searchIcons.png,v <-- searchIcons.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/themeGeneric-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/themeGeneric-aero.png,v <-- themeGeneric-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/themeGeneric.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/themeGeneric.png,v <-- themeGeneric.png new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/mozapps/extensions/viewButtons-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewButtons-aero.png,v <-- viewButtons-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/viewButtons.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewButtons.png,v <-- viewButtons.png new revision: 1.7; previous revision: 1.6 done Checking in toolkit/themes/winstripe/mozapps/passwordmgr/key-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/passwordmgr/key-aero.png,v <-- key-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/passwordmgr/key.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/passwordmgr/key.png,v <-- key.png new revision: 1.3; previous revision: 1.2 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/defaultFavicon-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/places/defaultFavicon-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/defaultFavicon-aero.png,v <-- defaultFavicon-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/places/defaultFavicon.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/defaultFavicon.png,v <-- defaultFavicon.png new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/tagContainerIcon-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/places/tagContainerIcon-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/tagContainerIcon-aero.png,v <-- tagContainerIcon-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/places/tagContainerIcon.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/places/tagContainerIcon.png,v <-- tagContainerIcon.png new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-aero.png,v <-- pluginGeneric-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/plugins/pluginGeneric.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric.png,v <-- pluginGeneric.png new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/extensionalert-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/update/extensionalert-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/extensionalert-aero.png,v <-- extensionalert-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/update/extensionalert.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/extensionalert.png,v <-- extensionalert.png new revision: 1.5; previous revision: 1.4 done RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/update-aero.png,v done Checking in toolkit/themes/winstripe/mozapps/update/update-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/update-aero.png,v <-- update-aero.png initial revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/update/update.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/update/update.png,v <-- update.png new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/mozapps/xpinstall/xpinstallItemGeneric-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/xpinstall/xpinstallItemGeneric-aero.png,v <-- xpinstallItemGeneric-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/xpinstall/xpinstallItemGeneric.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/xpinstall/xpinstallItemGeneric.png,v <-- xpinstallItemGeneric.png new revision: 1.5; previous revision: 1.4 done
Blocks: 423806, 423977
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Two issues visible in this screenshot, the search engine buttons, and the rating stars.
This should fix the close buttons and the get add-ons search bar. I'm going to go ahead and land this tonight before nightlies so we don't get tons of duplicates about the close buttons. I'll also be landing the matching gnomestripe parts of the get add-ons fix from bug 418868.
Attachment #310951 - Flags: review?(gavin.sharp)
Attachment #310951 - Flags: approval1.9b5?
(In reply to comment #9) > Created an attachment (id=310950) [details] > Problems with the new icons in the addons manager > > Two issues visible in this screenshot, the search engine buttons, and the > rating stars. > about rating tars, https://bugzilla.mozilla.org/show_bug.cgi?id=423137#c11
Checking in browser/themes/winstripe/browser/browser.css; /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css new revision: 1.190; previous revision: 1.189 done Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v <-- extensions.css new revision: 1.53; previous revision: 1.52 done Checking in toolkit/themes/winstripe/mozapps/extensions/searchIcons-aero.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/searchIcons-aero.png,v <-- searchIcons-aero.png new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/mozapps/extensions/searchIcons.png; /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/searchIcons.png,v <-- searchIcons.png new revision: 1.3; previous revision: 1.2 done
I missed a few tab close icons in my first patch. This gets the rest of them, I believe.
Attachment #310956 - Flags: review?(gavin.sharp)
Attachment #310956 - Flags: approval1.9b5?
Checking in browser/themes/winstripe/browser/browser.css; /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css new revision: 1.191; previous revision: 1.190 done Checking in browser/themes/winstripe/browser/places/organizer.css; /cvsroot/mozilla/browser/themes/winstripe/browser/places/organizer.css,v <-- organizer.css new revision: 1.5; previous revision: 1.4 done Checking in toolkit/themes/winstripe/global/findBar.css; /cvsroot/mozilla/toolkit/themes/winstripe/global/findBar.css,v <-- findBar.css new revision: 1.8; previous revision: 1.7 done Checking in toolkit/themes/winstripe/global/notification.css; /cvsroot/mozilla/toolkit/themes/winstripe/global/notification.css,v <-- notification.css new revision: 1.4; previous revision: 1.3 done Checking in toolkit/themes/winstripe/help/help.css; /cvsroot/mozilla/toolkit/themes/winstripe/help/help.css,v <-- help.css new revision: 1.23; previous revision: 1.22 done
Help>Help Contents icons are old style, will be changed or not ?
(In reply to comment #15) > Help>Help Contents > > icons are old style, will be changed or not ? No, the help viewer is being removed by bug 423486.
Allow this site to install add-on ( yellow bar pop up ) still has a broken tab button. Can you fix this one as well please.
Sorry for bug spam, but it seems it is broken in add-on manager as well as the main browser window. So this must be all yellow browser pop ups.
Apparently when we assembled the new icons we forgot to add the 1px of padding that had been around the buttons in close.png - crap. Reed: thanks for patching this on the tabstrip and searchbox Karl: you're referring to <notification> elements - reed, can we get a patch for those, too?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
seems to be no problem with close button, http://forums.mozillazine.org/viewtopic.php?p=3304742#3304742
Attachment #310956 - Flags: review?(gavin.sharp) → review+
Attachment #310951 - Flags: review?(gavin.sharp) → review+
These tab close icon regions look right to me!
I believe that the states should be: normal | hovered | pressed | inactive the newly checked in close.png has a grey background in the "normal" state, which makes it look inactive on luna (see http://img521.imageshack.us/my.php?image=zzvx8.jpg). Alex: can you update close.png and re-attach?
re comment 22: unless, uh - hm. Mossop points out that this might be by design, as they're darker than the background ones. If that's the case, then we can probably resolve this bug and if it turns out to be problematic open a new one.
Attachment #310951 - Flags: approval1.9b5? → approval1.9b5+
Attachment #310956 - Flags: approval1.9b5? → approval1.9b5+
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Mike it appears the hourly that I downloaded only had half the fixes in. It is all ok now. However I am not convinced to the look of the inactive icon. I feel it should have a border like in the fourth icon in comment 22. Also with eleven tabs open, the close icon is no longer there, is this by design? The maximum tabs I can have open and still keep the icon is currently 8?
Depends on: 424431
Depends on: 424463
Addon icons look nice:) But has anyone considered changing the hue of the 'Plugin' icon, making it red? It might be much better, because there is already a blue icon.
Depends on: 420551
The home icon is ~2px too low in all states. IMO, the colour of the roof should be a bit darker on XP - it's almost invisible when using the "Default (blue)" visual style. Wrt the tab close button on Vista: I think it should be more like IE, with a simple toolbarbutton appearance on hover and not a blue background. (I keep hearing that the blue is to make it feel lighter - here, it feels heavier than IE's grey close button.) (In reply to comment #24) > Also with eleven tabs open, the close icon is no longer there, is this by > design? The maximum tabs I can have open and still keep the icon is > currently 8? By design, to make more of the titles visible.
No longer depends on: 420551
Depends on: 424286
Depends on: 424603
{Build ID: 2008032216} http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/pageInfo-aero.png On Vista, pageInfo-aero.png is not used. Luna style icon (pageInfo.png) is used. (jar:classic.jar!/skin/classic/aero/browser/pageInfo.png is Luna style icon)
(In reply to comment #27) > On Vista, pageInfo-aero.png is not used. Luna style icon (pageInfo.png) is > used. Thanks, fixed. Checking in jar.mn; /cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v <-- jar.mn new revision: 1.82; previous revision: 1.81 done
(In reply to comment #22) > Created an attachment (id=310986) [details] > close.png - the first state is wrong, I think > > I believe that the states should be: > > normal | hovered | pressed | inactive > > the newly checked in close.png has a grey background in the "normal" state, > which makes it look inactive on luna (see > http://img521.imageshack.us/my.php?image=zzvx8.jpg). I confirm this, I thought my "close tab" button was disabled !
Filed bug 424996 for the close tab button on XP issue.
Depends on: 424996
Attached image New close.png —
Here is a new close.png file to land
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: