428440 - move code to set new product and related groups from process_bug.cgi to new function $bug->set_all

Status: RESOLVED DUPLICATE of bug 556407

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Noura Elhawary]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.9) Gecko/20070209 Fedora/1.5.0.9-3.fc6 Firefox/1.5.0.9 pango-text
Build Identifier: 

moving setting new product for bugs and its related groups from process_bug.cgi to Bugzilla::Bug::set_all()

Reproducible: Always

Comment 1

[Noura Elhawary]

Attachment: v1 patch for moving set a new product for bugs and update its related groups to $bug->set_all

HI,, attached is the first part for moving code from process_bug.cgi to function set_all,, please note that I have left the variable $product_change used to check strict isolation is both places as it is needed in now in both places, later it will be deleted from process_bug.cgi.

Please review when you can.

Thanks,
Noura

Comment 2

[Noura Elhawary]

Attachment: v2 patch for moving set a new product for bugs and update its related groups to $bug->set_all

please ignore previous patch,, fixed an error related to $product_change variable

Comment 3

[Frédéric Buclin]

Comment on attachment 315014 [details] [diff] [review]
v2 patch for moving set a new product for bugs and update its related groups to $bug->set_all

>Index: process_bug.cgi

>+    $product_change ||= $changed

Nit: missing semi-colon at the end of the line.


I didn't test the patch, but it looks good. Max, is it how you want set_all() to work?

Comment 4

[Frédéric Buclin]

CC'ing Max in case he didn't see my last question.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 315014 [details] [diff] [review]
v2 patch for moving set a new product for bugs and update its related groups to $bug->set_all

Yeah, for now. However, should_set shouldn't be necessary, and it would be nice to eliminate more code. But we can do that in a cleanup-type bug.

Comment 6

[Frédéric Buclin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.411; previous revision: 1.410
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.244; previous revision: 1.243
done

Comment 7

[Frédéric Buclin]

This patch has been backed out as it was responsible for bug 532493.