556407 - Move the code for setting product and checking strict_isolation into Bugzilla::Bug::set_all

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this moves product-setting into set_all and does a bit of refactoring.

  For a long time I've had that strict_isolation check in process_bug at the end, and was really worried that customizers or extensions were going to do set_product without remembering to do the strict_isolation check, thus breaking strict_isolation. So, now I've made set_product into _set_product, and left a comment informing code-readers that they must use set_all in order to set the product, not set_all.

  I also did some minor code cleanup in _set_product.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 436363 [details] [diff] [review]
v1

Code looks good and works as expected. r=dkl

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
modified Bugzilla/Bug.pm
Committed revision 7193.

Comment 5

[Max Kanat-Alexander]

Added to the release notes in bug 604256.