428557 - Error in console: NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Marcia Knous [:marcia]]

Seen while testing Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041104 Minefield/3.0pre.

STR:
Not sure, I got this message in the error console and it just sounded bad and I haven't seen it previously:

Error: [Exception... "'JavaScript component does not have a method named: "onStateChange"' when calling method: [nsIDownloadProgressListener::onStateChange]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: file:///Users/marcia/Desktop/LatestTrunk/Minefield.app/Contents/MacOS/components/nsHelperAppDlg.js :: anonymous :: line 798" data: no]
Source File: file:///Users/marcia/Desktop/LatestTrunk/Minefield.app/Contents/MacOS/components/nsHelperAppDlg.js
Line: 798

Comment 1

[:Gavin Sharp [email: [e-mail]]]

That's an odd exception - the progressListener object we set as the progress listener on nsExternalHelperAppService certainly does have an onStateChange method.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I've found the real problem:

http://mxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#6693

But I haven't figured out why the error message is so misleading...

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Silly.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 315186 [details] [diff] [review]
Patch

r=me

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 315186 [details] [diff] [review]
Patch

Very simple, zero-risk patch to keep the error console clean whenever downloading a file.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #2)
> But I haven't figured out why the error message is so misleading...

I know why now, and sadly there's almost nothing we can do about it. See bug 428590.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315186 [details] [diff] [review]
Patch

a1.9=beltzner

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed.

Comment 10

[cmtalbert]

Verified on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050704 Minefield/3.0pre

Comment 11

[Paul Heil]

I'm seeing this error in the console still with the latest 3.0pre build.  The error occurs when typing in an autocomplete textbox in my extension.

Error: [Exception... "'JavaScript component does not have a method named: "getImageAt"' when calling method: [nsIAutoCompleteResult::getImageAt]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]

Comment 12

[Paul Heil]

Attachment: Extension Testcase for Bug 428557. Toolbar w/autocomplete field

After installing start typing "12345" into textbox to see the error console flood with errors.

Comment 13

[Paul Heil]

Appears that the error was due to an update of the nsSearchSuggestions.js script not a regression.  Misleading error didn't help me figure that out.